Skip to content

[MOB-9999] Aggregate user update event gets deleted #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: AUT_main
Choose a base branch
from
Open

[MOB-9999] Aggregate user update event gets deleted #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7339339
prettify code
darshan-iterable Oct 18, 2024
4546fb6
[MOB-9703] Added support for fetching new JWT prior to calling merge
darshan-iterable Oct 18, 2024
fdc244d
[MOB-9999] Aggregate user update event gets deleted
darshan-iterable Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 66 additions & 46 deletions src/anonymousUserTracking/anonymousUserEventManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
KEY_PREFER_USERID,
ENDPOINTS,
DEFAULT_EVENT_THRESHOLD_LIMIT,
SHARED_PREF_ANON_USAGE_TRACKED
SHARED_PREF_ANON_USAGE_TRACKED,
SHARED_PREFS_USER_UPDATE_OBJECT_KEY
} from '../constants';
import { baseIterableRequest } from '../request';
import { IterableResponse } from '../types';
Expand Down Expand Up @@ -99,7 +100,7 @@
JSON.stringify(outputObject)
);
} catch (error) {
console.error('Error updating anonymous session:', error);

Check warning on line 103 in src/anonymousUserTracking/anonymousUserEventManager.ts

View workflow job for this annotation

GitHub Actions / build 

Unexpected console statement
}
}

Expand All @@ -115,7 +116,7 @@
validation: {}
})
.then((response) => {
const criteriaData: any = response.data;

Check warning on line 119 in src/anonymousUserTracking/anonymousUserEventManager.ts

View workflow job for this annotation

GitHub Actions / build 

Unexpected any. Specify a different type
if (criteriaData) {
localStorage.setItem(
SHARED_PREFS_CRITERIA,
Expand All @@ -124,7 +125,7 @@
}
})
.catch((e) => {
console.log('response', e);

Check warning on line 128 in src/anonymousUserTracking/anonymousUserEventManager.ts

View workflow job for this annotation

GitHub Actions / build 

Unexpected console statement
});
}

Expand All @@ -136,15 +137,15 @@
[KEY_CREATE_NEW_FIELDS]: true,
[SHARED_PREFS_EVENT_TYPE]: TRACK_EVENT
};
this.storeEventListToLocalStorage(newDataObject, false);
this.storeEventListToLocalStorage(newDataObject);
}

async trackAnonUpdateUser(payload: UpdateUserParams) {
const newDataObject = {
...payload.dataFields,
[SHARED_PREFS_EVENT_TYPE]: UPDATE_USER
};
this.storeEventListToLocalStorage(newDataObject, true);
this.storeUserUpdateToLocalStorage(newDataObject);
}

async trackAnonPurchaseEvent(payload: TrackPurchaseRequestParams) {
Expand All @@ -155,7 +156,7 @@
[KEY_TOTAL]: payload.total,
[SHARED_PREFS_EVENT_TYPE]: TRACK_PURCHASE
};
this.storeEventListToLocalStorage(newDataObject, false);
this.storeEventListToLocalStorage(newDataObject);
}

async trackAnonUpdateCart(payload: UpdateCartRequestParams) {
Expand All @@ -165,21 +166,27 @@
[KEY_PREFER_USERID]: true,
[KEY_CREATED_AT]: this.getCurrentTime()
};
this.storeEventListToLocalStorage(newDataObject, false);
this.storeEventListToLocalStorage(newDataObject);
}

private checkCriteriaCompletion(): string | null {
const criteriaData = localStorage.getItem(SHARED_PREFS_CRITERIA);
const localStoredEventList = localStorage.getItem(
SHARED_PREFS_EVENT_LIST_KEY
);
const localStoredUserUpdate = localStorage.getItem(
SHARED_PREFS_USER_UPDATE_OBJECT_KEY
);
try {
if (criteriaData && localStoredEventList) {
const checker = new CriteriaCompletionChecker(localStoredEventList);
const checker = new CriteriaCompletionChecker(
localStoredEventList,
localStoredUserUpdate
);
return checker.getMatchedCriteria(criteriaData);
}
} catch (error) {
console.error('checkCriteriaCompletion', error);

Check warning on line 189 in src/anonymousUserTracking/anonymousUserEventManager.ts

View workflow job for this annotation

GitHub Actions / build 

Unexpected console statement
}

return null;
Expand All @@ -191,14 +198,11 @@
if (!anonymousUsageTracked) return;

const userData = localStorage.getItem(SHARED_PREFS_ANON_SESSIONS);
const eventList = localStorage.getItem(SHARED_PREFS_EVENT_LIST_KEY);
const events = eventList ? JSON.parse(eventList) : [];
const strUserUpdate = localStorage.getItem(
SHARED_PREFS_USER_UPDATE_OBJECT_KEY
);
const dataFields = strUserUpdate ? JSON.parse(strUserUpdate) : {};

const dataFields = {
...events.find(
(event: any) => event[SHARED_PREFS_EVENT_TYPE] === UPDATE_USER
)
};
delete dataFields[SHARED_PREFS_EVENT_TYPE];

const userId = uuidv4();
Expand Down Expand Up @@ -238,15 +242,7 @@
}
});
if (response?.status === 200) {
// Update local storage, remove updateUser from local storage
localStorage.setItem(
SHARED_PREFS_EVENT_LIST_KEY,
JSON.stringify(
events.filter(
(event: any) => event[SHARED_PREFS_EVENT_TYPE] !== UPDATE_USER
)
)
);
localStorage.removeItem(SHARED_PREFS_USER_UPDATE_OBJECT_KEY);

const onAnonUserCreated = config.getConfig('onAnonUserCreated');

Expand All @@ -267,6 +263,11 @@
? JSON.parse(strTrackEventList)
: [];

const strUserUpdate = localStorage.getItem(
SHARED_PREFS_USER_UPDATE_OBJECT_KEY
);
const userUpdateObject = strUserUpdate ? JSON.parse(strUserUpdate) : {};

if (trackEventList.length) {
trackEventList.forEach(
(
Expand All @@ -288,30 +289,32 @@
this.updateCart(event);
break;
}
case UPDATE_USER: {
this.updateUser({ dataFields: event });
break;
}
default:
break;
}
this.removeAnonSessionCriteriaData();
}
);
}

if (Object.keys(userUpdateObject).length) {
// eslint-disable-next-line no-param-reassign
delete userUpdateObject[SHARED_PREFS_EVENT_TYPE];
this.updateUser(userUpdateObject);
}
}

removeAnonSessionCriteriaData() {
localStorage.removeItem(SHARED_PREFS_ANON_SESSIONS);
localStorage.removeItem(SHARED_PREFS_EVENT_LIST_KEY);
localStorage.removeItem(SHARED_PREFS_USER_UPDATE_OBJECT_KEY);
}

private async storeEventListToLocalStorage(
newDataObject: Record<
any /* eslint-disable-line @typescript-eslint/no-explicit-any */,
any /* eslint-disable-line @typescript-eslint/no-explicit-any */
>,
shouldOverWrite: boolean
>
) {
const anonymousUsageTracked = isAnonymousUsageTracked();

Expand All @@ -324,24 +327,7 @@
previousDataArray = JSON.parse(strTrackEventList);
}

if (shouldOverWrite) {
const trackingType = newDataObject[SHARED_PREFS_EVENT_TYPE];
const indexToUpdate = previousDataArray.findIndex(
(obj: any) => obj[SHARED_PREFS_EVENT_TYPE] === trackingType
);
if (indexToUpdate !== -1) {
const dataToUpdate = previousDataArray[indexToUpdate];

previousDataArray[indexToUpdate] = {
...dataToUpdate,
...newDataObject
};
} else {
previousDataArray.push(newDataObject);
}
} else {
previousDataArray.push(newDataObject);
}
previousDataArray.push(newDataObject);

// - The code below limits the number of events stored in local storage.
// - The event list acts as a queue, with the oldest events being deleted
Expand All @@ -366,6 +352,40 @@
}
}

private async storeUserUpdateToLocalStorage(
newDataObject: Record<
any /* eslint-disable-line @typescript-eslint/no-explicit-any */,
any /* eslint-disable-line @typescript-eslint/no-explicit-any */
>
) {
const anonymousUsageTracked = isAnonymousUsageTracked();

if (!anonymousUsageTracked) return;

const strUserUpdate = localStorage.getItem(
SHARED_PREFS_USER_UPDATE_OBJECT_KEY
);
let userUpdateObject = {};

if (strUserUpdate) {
userUpdateObject = JSON.parse(strUserUpdate);
}

userUpdateObject = {
...userUpdateObject,
...newDataObject
};

localStorage.setItem(
SHARED_PREFS_USER_UPDATE_OBJECT_KEY,
JSON.stringify(userUpdateObject)
);
const criteriaId = this.checkCriteriaCompletion();
if (criteriaId !== null) {
this.createKnownUser(criteriaId);
}
}

private getCurrentTime = () => {
const dateInMillis = new Date().getTime();
const dateInSeconds = Math.floor(dateInMillis / 1000);
Expand Down
Loading