-
Notifications
You must be signed in to change notification settings - Fork 31
MOB-11639 WIP: Async Initialization for ANR Prevention #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sumeruchat
wants to merge
13
commits into
master
Choose a base branch
from
feature/MOB-11639-async-initialization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… structure in IterableKeychain.kt- Enhanced test coverage and refactored tests in IterableKeychainTest.kt- Added 421 lines and removed 236 lines across both files
This reverts commit e8ff15e.
This reverts commit d0a4547.
…enable on foreground" This reverts commit f46c0f9.
…d `InitializationState` enum for managing SDK initialization states.- Added `waitForInitialization` method to ensure synchronous test setup.- Implemented `executeWhenReady` to queue operations until initialization completes.- Utilized `ExecutorService` for background initialization tasks.- Improved `IterableKeychain` with non-blocking cache access and async value saving.- Updated test utilities to wait for initialization.
…- Improved code structure and readability- Added 363 lines of new tests and functionality- Removed 229 lines of redundant or outdated code
…java` with improved logic and reduced complexity.- Added new functionality in `IterableApiInitializer.kt`.- Refactored `IterableKeychain.kt` for better performance and maintainability.- Enhanced test coverage in `IterableKeychainTest.kt`.- Minor build configuration updates in `build.gradle`.Overall, 470 lines added and 499 lines removed to streamline codebase.
…hared preferences to return encrypted data.- Simulate timeout by throwing an exception in mockEncryptor.- Verify decryption failure handler is called.- Ensure bad encrypted data is removed.
…s when ready- Wrapped logic in executeWhenReady to ensure actions are performed when the system is ready.- Improved code readability and maintainability by encapsulating logic within a lambda.
…ructure- Removed redundant code from IterableApi.java, reducing complexity.- Deleted IterableApiInitializer.kt as it was no longer needed.- Simplified IterableTestUtils.java and updated build.gradle accordingly.- Overall, 91 insertions and 332 deletions across 6 files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress async initialization framework