Make readClientRequest fallible #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AeroStun
reviewed
May 19, 2025
| namespace { | ||
|
|
||
| [[nodiscard]] ClientRequest readClientRequest(std::span<const std::byte>& buf) noexcept { | ||
| [[nodiscard]] constexpr io::expected<std::optional<ClientRequest>> |
There was a problem hiding this comment.
Instead of nesting things, can we only use the expected and put std::errc::invalid_argument if the input is garbage?
There was a problem hiding this comment.
the idea is that if the optional is empty then we need more bytes, if there is an unexpected value then the input is garbage. We can make a new error code that says like "give me more bytes" or something to flatten it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that it can be called with malformed data and not bring down the process