Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.x #126

Merged
merged 81 commits into from
Jun 4, 2012
Merged

6.x #126

merged 81 commits into from
Jun 4, 2012

Conversation

adam-vessey
Copy link

Refactors, rewrites, and cleanups...

Everything between d36fdd2 and 48c1551 can be ignored... Did some combination of a rebase and merge which seems to have made a mess of things. (Also smaller "fix" commits in that range were squashed into the surrounding commits, and so are not duplicated later)

Mentionable are commits:

  • c3ccdec: Allow redirect/reference streams in the add/replace form (from the detailed list of content). Disabled by default (to offer the current functionality; can be enabled in "Advaced" islandora config)
  • c76891f and 6370a12: Using Sparql for breadcrumbs, and avoiding creating an entry for the current object.
  • c014959: Addition of the page parameter to the islandora_tabs call, so functionality of the IslandoraCM classes can be duplicated.
  • 7749a2f: Create a function to render an image (produce the image markup), which can make use of imagecache external if it is available.

adam-vessey and others added 30 commits July 18, 2011 10:04
FlowPlayer requires the "Content-Length" header to be returned in order to work properly,
but it wasn't getting returned in the header when a user was not logged in.
A slight change to the semantics, and opening up of the getDatastream API-M method via
XACML seems to work.
Had to do with migration to use of newer REST API; it takes the version
parameter differently, as a query parameter instead of a position in the
URL.
Error intro'd during datastream replace 'improvements'.
...  As opposed to spitting out markup for it directly.
Conflicts:
	ObjectHelper.inc - fix content size acquisition
Was using wrong variable name.
The XSLT will still be used if it is present, though.
Was able to instantiate without a PID, which would mean that the
'collectionObject' object helper would not get created...  Blargh.
...  Facilitates implementation of equivalent functionality, where
the object was instantiated with the PID, and then the page was
passed to the method declared in your ISLANDORACM stream.
Should make the length an actual configurable value...  Shouldn't be hard, though.
...  Including those provided by islandora proper.
Called just before return of drupal_render()'d markup.  Passed the
tabset and associative array of the parameters with which
hook_islandora_tabs() was called; that is:
array(
  'content_models' => {an array of ContentModel objects},
  'pid' => {the PID of the object being rendered},
  'page' => {the page of the object to be displayed},
)
adam-vessey and others added 28 commits May 4, 2012 11:35
This function tries to make use of imagecache(_external) if it is
avaiable; otherwise, falls back to using theme('image').
Also, use imagecache_external!
…ge to request all profiles and create a table for user selection
Conflicts:
	plugins/tagging_form.inc - both introduced slightly different fixes...
Can now use some basic typing (int, string) for RDF literals.
jonathangreen pushed a commit that referenced this pull request Jun 4, 2012
@jonathangreen jonathangreen merged commit f9ddf29 into Islandora:6.x Jun 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants