Skip to content

Commit

Permalink
Merge pull request #103 from tianyuma1/BR_USER_PASSWORD
Browse files Browse the repository at this point in the history
Support passowrd setting when creating users
  • Loading branch information
shirleylxie authored Apr 11, 2022
2 parents bcc774a + c921ca0 commit 59a49f3
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
7 changes: 7 additions & 0 deletions src/isilon_hadoop_tools/_scripts.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ def isilon_create_users_cli(parser=None):
type=int,
default=isilon_hadoop_tools.identities.Creator.default_start_uid,
)
parser.add_argument(
'--user-password',
help='the password for users created',
type=str,
default=None,
)
return parser


Expand Down Expand Up @@ -112,6 +118,7 @@ def isilon_create_users(argv=None):
start_uid=args.start_uid,
start_gid=args.start_gid,
script_path=os.path.join(os.getcwd(), name + '.sh'),
user_password=args.user_password,
)
if args.dry:
LOGGER.info(DRY_RUN)
Expand Down
3 changes: 3 additions & 0 deletions src/isilon_hadoop_tools/identities.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,14 @@ def __init__( # pylint: disable=too-many-arguments
start_uid=default_start_uid,
start_gid=default_start_gid,
script_path=None,
user_password=None,
):
self.onefs = onefs
self.onefs_zone = onefs_zone
self._next_uid = start_uid
self._next_gid = start_gid
self.script_path = script_path
self.user_password = user_password

@property
def next_gid(self):
Expand Down Expand Up @@ -240,6 +242,7 @@ def create_user(self, user_name, primary_group_name):
primary_group_name=primary_group_name,
zone=self.onefs_zone,
enabled=True,
password=self.user_password,
)
break
except isilon_hadoop_tools.onefs.APIError as exc:
Expand Down
3 changes: 2 additions & 1 deletion src/isilon_hadoop_tools/onefs.py
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,7 @@ def create_spn(self, spn, realm, user, password):
self._sdk.AuthApi(self._api_client).create_providers_krb5_item(providers_krb5_item)

@accesses_onefs
def create_user(self, name, primary_group_name, uid=None, zone=None, enabled=None):
def create_user(self, name, primary_group_name, uid=None, zone=None, enabled=None, password=None):
"""Create a user."""
group_member_cls = (
self._sdk.GroupMember
Expand All @@ -899,6 +899,7 @@ def create_user(self, name, primary_group_name, uid=None, zone=None, enabled=Non
name=primary_group_name,
),
uid=uid,
password=password,
),
zone=zone or self.default_zone,
)
Expand Down

0 comments on commit 59a49f3

Please sign in to comment.