Improve error formatting #488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhangYiJiang
commented
Mar 19, 2025
| ), | ||
| ), | ||
| ` | ||
| Multiple errors |
There was a problem hiding this comment.
Would prefer snapshots for stuff like this, but I don't think there's an easy way to do this with the native package
|
I think from reading the code recordings store and re-emit errors as strings, it might be useful to use this function there too but I'm having a little difficulty finding that place |
|
This is great! Can we use it in the UI when displaying node errors? Or when showing errors in the console? |
|
Sure, can you point to where that is in the code? Or feel free to push up the changes onto this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new error formatter for prettifying errors emitted from Rivet. To do this I've attached the ChartNode object to the Error itself - it's not great but I think this is the best way to propagate node info to the formatter without having to add another wrapping Error class