Mcp #478

suhail-ak-s · 2025-02-20T13:17:15Z

Add Model Context Protocol (MCP) Integration

Description

This PR adds support for the Model Context Protocol (MCP), enabling seamless integration with external AI capabilities, tools, and resources through a standardized protocol. The implementation includes both HTTP and STDIO communication modes, making it flexible for different deployment scenarios.

Key Features

New MCPNode for handling MCP communications
Support for both HTTP and STDIO communication modes
Dynamic tool discovery from MCP servers
Configurable server endpoints and headers
Browser-compatible implementation with appropriate polyfills
Proper error handling and type safety

Implementation Details

Added MCPNode class with full TypeScript type safety
Implemented browser polyfills for Node.js specific modules
Added configuration support through mcp-config.json
Integrated with existing native API infrastructure
Added proper error handling with specific error types
Support for dynamic tool discovery and metadata handling

Technical Considerations

Browser compatibility maintained through polyfills
Proper TypeScript types throughout the implementation
Error handling follows existing patterns
Configuration follows project conventions
No breaking changes to existing functionality

Testing

The implementation includes:

Type safety checks
Error handling for various scenarios
Browser environment compatibility
Support for both communication modes

Documentation

Added inline documentation for the MCP node
Included type definitions for all new interfaces
Added helper messages in the UI for configuration

Breaking Changes

None. This is a purely additive change that maintains compatibility with existing functionality.

Future Considerations

Additional tool discovery mechanisms
Enhanced error reporting
Extended configuration options
Performance optimizations for large-scale deployments

abrenneke

Here's a first pass review!

abrenneke · 2025-02-20T17:45:19Z

package.json

@@ -55,7 +55,8 @@
  },
  "dependencies": {
    "@ironclad/rivet-core": "workspace:^",
-    "@ironclad/rivet-node": "workspace:^"
+    "@ironclad/rivet-node": "workspace:^",
+    "@modelcontextprotocol/sdk": "^1.5.0"


We should add this to the individual packages, not the root package.json

abrenneke · 2025-02-20T17:45:50Z

packages/app/src/assets/node_images/mcp_node.png

Can we have a better node body? Maybe it's just the example, but a blank body doesn't seem very helpful?

abrenneke · 2025-02-25T01:58:33Z

packages/app/vite.config.ts

    alias: {
      '@ironclad/rivet-core': resolve('../core/src/index.ts'),
      '@ironclad/trivet': resolve('../trivet/src/index.ts'),
+      // 'node:child_process': resolve('./src/mocks/node-polyfills.ts'),


Looks like we don't need these any more?

yes this is removed

abrenneke · 2025-02-25T01:58:41Z

packages/app/src/mocks/node-polyfills.ts

@@ -0,0 +1,116 @@
+// Mock implementation for node:child_process
+export const spawn = () => {


Looks like we don't need this file any more?

it came back

abrenneke · 2025-02-25T02:05:06Z

packages/app/vite.config.ts

@@ -34,6 +52,10 @@ export default defineConfig({
      plugins: [visualizer()],
    },
  },
+  // define: {


abrenneke · 2025-02-25T02:10:53Z

packages/core/src/model/nodes/MCPNode.ts

+        label: 'Configuration',
+        dataKey: 'config',
+        useInputToggleDataKey: 'useEndpointInput',
+        helperMessage: 'Configuration for the MCP server' });


Can you please run prettier on this file?

prettier is done

abrenneke · 2025-02-25T02:12:05Z

packages/core/src/model/nodes/docs/README.md

@@ -0,0 +1,235 @@
+# MCP Node for Rivet


Can you move these docs into the docs project? And structure it like the existing per-node documentation?

abrenneke · 2025-02-25T02:12:47Z

packages/node/src/native/NodeNativeApi.ts

      ignores = [],
    } = options;

+    const resolvedPath = await resolveBaseDir(baseDir, path);
+    console.log('Reading directory from path:', resolvedPath);


Need to remove this and other console logs in the file

removed console.log

abrenneke · 2025-02-25T02:18:46Z

packages/core/src/model/nodes/MCPNode.ts

+  ): Promise<{ output: string; metadata: Record<string, unknown> }> {
+    let configFile: object;
+    try {
+      configFile = this.data.useEndpointInput


Should be behind a different data flag, not useEndpointInput

yes changed...

abrenneke · 2025-02-25T02:19:17Z

packages/core/src/model/nodes/MCPNode.ts

+      throw new MCPError(MCPErrorType.INVALID_RESPONSE, 'Invalid format for MCP configuration');
+    }
+
+    const serverId = this.data.useEndpointInput


You can use getInputOrData for this pattern, getInputOrData(this.data, inputs, 'serverId')

arbaaz · 2025-02-27T04:28:46Z

This looks great!

Quick question:

Will this work in node integration using runGraphInFile?

abrenneke · 2025-03-02T00:02:26Z

packages/app/src/mocks/node-polyfills.ts

@@ -0,0 +1,116 @@
+// Mock implementation for node:child_process
+export const spawn = () => {


it came back

abrenneke · 2025-03-02T00:02:39Z

packages/app/vite.config.ts

    alias: {
      '@ironclad/rivet-core': resolve('../core/src/index.ts'),
      '@ironclad/trivet': resolve('../trivet/src/index.ts'),
+      'node:child_process': resolve('./src/mocks/node-polyfills.ts'),


Why were these added back in?

abrenneke · 2025-03-02T00:03:51Z

packages/core/package.json

@@ -48,6 +48,8 @@
    "@google-cloud/vertexai": "^0.1.3",
    "@google/generative-ai": "^0.21.0",
    "@huggingface/inference": "^2.6.4",
+    "@modelcontextprotocol/sdk": "^1.5.0",
+    "@tauri-apps/api": "^1.5.3",


Core cannot depend on tauri

suhail-ak-2 and others added 6 commits February 20, 2025 12:40

Add MCP (Model Context Protocol) Node and SDK Integration

e02bcd4

Add browser polyfills and Node.js module mocks for web compatibility

c20136c

Update contributor information for anna-mariakv

2258970

Add comprehensive MCP Node documentation for Rivet

aaf7f16

Remove Node.js module polyfills and global definitions in Vite config

2d26fc5

Enhance MCP Node with flexible configuration and input handling

1401fac

abrenneke reviewed Feb 25, 2025

View reviewed changes

Remove @modelcontextprotocol/sdk dependency and related configurations

4e54d5f

Add Node.js module polyfills for browser compatibility

ef20a58

abrenneke requested changes Mar 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mcp #478

Mcp #478

suhail-ak-s commented Feb 20, 2025

abrenneke left a comment

abrenneke Feb 20, 2025

suhail-ak-s Feb 26, 2025

abrenneke Feb 20, 2025

suhail-ak-s Feb 26, 2025

abrenneke Feb 25, 2025

suhail-ak-s Feb 26, 2025

abrenneke Feb 25, 2025

suhail-ak-s Feb 26, 2025

abrenneke Mar 2, 2025

abrenneke Feb 25, 2025

suhail-ak-s Feb 26, 2025

abrenneke Feb 25, 2025

suhail-ak-s Feb 26, 2025

abrenneke Feb 25, 2025

suhail-ak-s Feb 26, 2025

abrenneke Feb 25, 2025

suhail-ak-s Feb 26, 2025

abrenneke Feb 25, 2025

suhail-ak-s Feb 26, 2025

abrenneke Feb 25, 2025

arbaaz commented Feb 27, 2025

abrenneke Mar 2, 2025

abrenneke Mar 2, 2025

abrenneke Mar 2, 2025

		@@ -0,0 +1,116 @@
		// Mock implementation for node:child_process
		export const spawn = () => {

Mcp #478

Are you sure you want to change the base?

Mcp #478

Conversation

suhail-ak-s commented Feb 20, 2025

Add Model Context Protocol (MCP) Integration

Description

Key Features

Implementation Details

Technical Considerations

Testing

Documentation

Breaking Changes

Future Considerations

abrenneke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arbaaz commented Feb 27, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment