Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .swift-version, use Podspec swift_versions #171

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

bobgilmore
Copy link
Contributor

Whenever we update the pod and publish to Cocoapods,
pod spec lint
warns us that

Usage of the .swift_version file has been deprecated!...

Let's clean it up and replace it with swift_versions in the podspec
per lint's recommendation.

See issue #169 in the repo.

Whenever we update the pod and publish to Cocoapods,
pod spec lint
warns us that
Usage of the .swift_version file has been deprecated!

Let's clean it up and replace it with swift_versions in the podspec
per lint's recommendation.

See issue #169 in the repo.
@ipbuildserver
Copy link

5 Warnings
⚠️ ResultTests.swift#L15 - SwiftWisdomTests/CommonTypes/ResultTests.swift#L15: ‘IPResult’ is deprecated: use Swift.Result instead
private final let successfulResult = IPResult<Int>.success(1)
⚠️ ResultTests.swift#L16 - SwiftWisdomTests/CommonTypes/ResultTests.swift#L16: ‘IPResult’ is deprecated: use Swift.Result instead
private final let failureResult = IPResult<Any>.failure(ResultError.error)
⚠️ UnsignedInteger+ExtensionsTests.swift#L16 - SwiftWisdomTests/StandardLibrary/Numbers/UnsignedInteger+ExtensionsTests.swift#L16: ‘random(inRange:)’ is deprecated: Use Int.random(in:) instead
XCTAssert(positives.contains(random(inRange: positives)))
⚠️ UnsignedInteger+ExtensionsTests.swift#L18 - SwiftWisdomTests/StandardLibrary/Numbers/UnsignedInteger+ExtensionsTests.swift#L18: ‘random(inRange:)’ is deprecated: Use Int.random(in:) instead
XCTAssert(negatives.contains(random(inRange: negatives)))
⚠️ UnsignedInteger+ExtensionsTests.swift#L20 - SwiftWisdomTests/StandardLibrary/Numbers/UnsignedInteger+ExtensionsTests.swift#L20: ‘random(inRange:)’ is deprecated: Use Int.random(in:) instead
XCTAssert(mixed.contains(random(inRange: mixed)))
1 Message
📖 Executed 174 tests, with 0 failures (0 unexpected) in 0.429 (0.488) seconds

Generated by 🚫 Danger

@bobgilmore
Copy link
Contributor Author

bobgilmore commented Oct 4, 2019

I didn't update the version in the "main" Podspec, because PR 170 handles that for me. I'll merge this one, then tag this one, merge, and push to trunk.

@bobgilmore bobgilmore merged commit f579601 into master Oct 4, 2019
@bobgilmore bobgilmore deleted the bobgilmore/remove-swift-version-files branch October 7, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants