TRAN-5264: SEPTA: Trolley translator

Removing stop id from constructor as it is available in feed.
Intersection · Jun 25, 2021 · 9b6fc43 · 9b6fc43
1 parent f62e495
commit 9b6fc43
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/gtfs_realtime_translators/translators/septa_trolley_lines.py b/gtfs_realtime_translators/translators/septa_trolley_lines.py
@@ -7,17 +7,16 @@
 
 
 class SeptaTrolleyLineTranslator:
-    def __init__(self, stop_id=None):
-        if stop_id is None:
-            raise ValueError('stop_id is required.')
-
-        self.stop_id = stop_id
 
     def __call__(self, data):
         json_data = json.loads(data)
         entities = []
         for data in json_data["data"]["predictionsData"]:
-            trip_updates = self.__make_trip_updates(data, self.stop_id)
+            stop_id = data.get("stopId", None)
+            if stop_id is None:
+                raise ValueError('stop_id is required.')
+
+            trip_updates = self.__make_trip_updates(data, stop_id)
             entities.extend(trip_updates)
 
         return FeedMessage.create(entities=entities)

diff --git a/test/test_septa_trolley_lines.py b/test/test_septa_trolley_lines.py
@@ -15,7 +15,7 @@ def septa_trolley_lines():
 
 
 def test_septa_trolley_data(septa_trolley_lines):
-    translator = SeptaTrolleyLineTranslator(stop_id='20646')
+    translator = SeptaTrolleyLineTranslator()
     with pendulum.test(pendulum.datetime(2021,6,16,12,0,0)):
         message = translator(septa_trolley_lines)