Split out ImmutableEraParams
#1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
requested review from
nfrisby,
jasagredo,
amesgen,
fraser-iohk and
dnadales
as code owners
geo2a
force-pushed
the
geo2a/split-up-pr-1288
branch
from
15aea3f to
95683bb
Compare
Add ImmutableEraParams instances for test blocks without needing the SingleEraBlock omnibus.
GHC 9.4+ "erroneously" requires HasHeader blk. This patch prevents that. I _think_ the new local signature forces GHC to invoke the HeaderHash (Header blk) ~ HeaderHash blk rewrite _later_, thereby avoiding that undesirable Wanted constraint.
It's declared upstream in Control.ResourceRegistry now.
geo2a
force-pushed
the
geo2a/split-up-pr-1288
branch
from
95683bb to
ff188ac
Compare
geo2a
force-pushed
the
geo2a/split-up-pr-1288
branch
from
ff188ac to
0191ab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts some small changes from #1288 in order to make the rebase of #1288 onto main more manageable.