fix(testrun): add timeouts for testrun #3236
Merged
+124
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoura
force-pushed
the
timeout_get_cluster_one_hour
branch
3 times, most recently
from
9e0df20 to
30802e8
Compare
Copilot finished reviewing on behalf of
mkoura
November 26, 2025 18:18
Introduce stricter checks for dead cluster instances as the test wait deadline approaches. Add configurable grace period, strict check window, and dead fraction threshold. Replace all-dead check with a fractional dead check to fail earlier when too many clusters are unavailable.
Added pytest-timeout v2.4.0 to dependencies to enable automatic abortion of hanging tests. Updated poetry.lock and pyproject.toml accordingly. This improves test reliability by preventing indefinite test runs.
Specify --timeout and --session-timeout options for target_tests, target_testpr, and target_testnets in .github/run_tests.sh. This ensures test runs have appropriate limits for duration and session, improving reliability and preventing hangs in CI workflows.
mkoura
force-pushed
the
timeout_get_cluster_one_hour
branch
from
da83034 to
4a86013
Compare
mkoura
changed the title
Introduce SESSION_TIMEOUT environment variable to set an overall timeout for the test session in .github/run_tests.sh. The test runner now uses the timeout command to enforce this limit. Default values are set for different targets. This helps prevent excessively long test runs and improves CI reliability.
Add a background system resource monitor to regression.sh that logs CPU, memory, and disk usage every 10 minutes to monitor.log. Ensure monitor is stopped on script exit. Include monitor.log as a workflow artifact for analysis.
mkoura
force-pushed
the
timeout_get_cluster_one_hour
branch
from
4a86013 to
7b94d09
Compare
Copilot finished reviewing on behalf of
mkoura
November 27, 2025 18:14
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the testrun could run indefinitely. These changes introduce a various timeouts to prevent hanging tests.