Use raw bytes representation instead of CBOR for CIP-129 identifier serialisation

[carbolymer]

Changelog

- description: |
    Use raw bytes representation instead of CBOR for CIP-129 identifier serialisation
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes:

• cardano-cli 10.11 produces wrong dRep CIP129 id cardano-cli#1254

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[Jimbo4350]

This should remain. It's explicit and it can be re-used instead of inlining it.

[carbolymer]

It's not a very useful class field (?). You still have to duplicate the constants when serialising - there's no easy way to have a two-way mapping between headers to type constructors.

[Jimbo4350]

I prefer explicit over inlining here.

[carbolymer]

I've pushed a commit reusing headers instead of inlining them.

[Jimbo4350]

What does Cee stand for?

[carbolymer]

"Cip Encoding Error". I guess I could use C129ee but it felt too long and not bringing any additional information over Cee.

[Jimbo4350]

Why not just use Cip129 as the prefix? Cee is ambiguous.

[Jimbo4350]

LGTM but read my comment. I think your prior changes were significantly more elegant and we can make the inlining more palatable by defining constants for the header bytes.

[Jimbo4350]

This is a departure from the simplicity of the changes you made in the previous commit. It looks like you were trying to include the ability to define the Cip129 GovActionId instance and that's where the trouble begins because it doesn't have a header byte like the other items in Cip129.

In that case, I would stick with your prior commit's changes and just implement values (with haddocks) for the header bytes and reuse those values in the same inlining fashion.

[Jimbo4350]

Nice 👍