Open
Conversation
deployment-working.yaml defines name: my-app, not frontend-service.
Steps went 1, 2, 3, 4, 6 — renaming to sequential 1–5.
Verification sections were numbered 1, 2, 4 — section 3 was absent.
…output The previous message 'Deployment violates quality standards' was invented. The actual sprintf format from quality-constraint-template.yaml line 34 produces the constraint name, percentage, minimum, and commit SHA in the denial message.
Replace vague 'sha for the working image has met the quality requirement' with a concrete explanation: which SHA maps to which percentage, why one is rejected and one allowed, and that the policy uses a static coverageData map (not live image scanning).
There was a problem hiding this comment.
Pull request overview
Updates the Quality module workshop documentation to better reflect Gatekeeper policy behavior and to improve instructional flow for the code coverage enforcement exercise.
Changes:
- Updated the expected Gatekeeper denial output to include commit-specific coverage details.
- Corrected the expected successful deployment output to match the
my-appmanifest. - Fixed step numbering and clarified how the constraint’s
coverageDatalookup drives allow/deny decisions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
workshop/capoc/quality/readme.mddocumentation to clarify the expected results and quality policy enforcement details in the deployment workflow. The changes improve the accuracy of command outputs, clarify the reasoning behind policy decisions, and correct step numbering for better instructional flow.Documentation and instructional improvements:
my-appinstead offrontend-service, aligning with the deployment manifest.coverageDatamap.Instructional corrections: