[Enhance] Set max queue size for async saving hf checkpoint #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAOCHENYE
force-pushed
the
yehc/fix-save-ckpt-cpuoom
branch
4 times, most recently
from
3918f7c to
57dd84b
Compare
hhaAndroid
approved these changes
Nov 11, 2025
`xtuner.v1.model.BaseModel.save_hf` using `ProcessPoolExecutor` to submit multiple saving tasks to accelerate the save speed. However, `ProcessPoolExecutor.submit` is nonblocking, it will accumulated lots of `cpu` tensor and will cause cpu oom.
HAOCHENYE
force-pushed
the
yehc/fix-save-ckpt-cpuoom
branch
from
57dd84b to
76e7bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xtuner.v1.model.BaseModel.save_hfusingProcessPoolExecutorto submit multiple saving tasks to accelerate the save speed. However,ProcessPoolExecutor.submitis nonblocking, it will accumulated lots ofcputensor and will cause cpu oom.