Rotate_depth_and_ir_frames_together #13940
Conversation
src/proc/rotation-filter.h
Outdated
| std::map< std::pair< rs2_stream, int >, rs2::stream_profile > _target_stream_profiles; | ||
| std::map< std::pair< rs2_stream, int >, rs2::stream_profile > _source_stream_profiles; | ||
| // Define a simple structure to hold rotated dimensions | ||
| struct RotatedDims |
There was a problem hiding this comment.
Let's align to the sdk naming convention
rotated_dims
src/proc/rotation-filter.cpp
Outdated
| tgt_type); | ||
| std::pair< rs2_stream, int > stream_key( f.get_profile().stream_type(), f.get_profile().stream_index() ); | ||
|
|
||
| if( _rotated_dimensions.find( stream_key ) == _rotated_dimensions.end() ) |
There was a problem hiding this comment.
On which case will this happen?
There was a problem hiding this comment.
Should not happen but I think it's OK to test.
There are cases where say update_output_profile returns without setting _rotated_dimensions, better to make sure we are aligned.
There was a problem hiding this comment.
@noacoohen, now that I think of it, do we really need _rotated_dimensions? I think the information is stored in _target_stream_profiles
There was a problem hiding this comment.
@OhadMeir removed it.
|
@OhadMeir / @noacoohen I played with it a bit and it looks OK. |
src/proc/rotation-filter.cpp
Outdated
| @@ -46,6 +46,8 @@ namespace librealsense { | |||
| if( ! strong_rotation_control ) | |||
| return; | |||
|
|
|||
| std::lock_guard< std::mutex > lock( _mutex ); | |||
There was a problem hiding this comment.
Why do we need this lock here?
There was a problem hiding this comment.
Nir suggested adding the lock — we figured, similar to the decimation filter, there might be cases where we need to ensure thread safety when updating _value
There was a problem hiding this comment.
We removed it on the last PR. We use a local copy of _value elsewhere to avoid locking.
Also, locking only here will not help, you need to lock on every use of the protected resource (_value in this case)
| rs2::frame rotation_filter::prepare_target_frame( const rs2::frame & f, | ||
| const rs2::frame_source & source, | ||
| const rs2::stream_profile & target_profile, | ||
| rs2_extension tgt_type ) | ||
| { | ||
| auto vf = f.as<rs2::video_frame>(); |
There was a problem hiding this comment.
Need to test cast success
No description provided.