Skip to content

Benchmark rambo #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 1, 2024
Merged

Benchmark rambo #9

merged 8 commits into from
Jul 1, 2024

Conversation

AllanZyne
Copy link
Collaborator

@AllanZyne AllanZyne commented May 6, 2024 •
edited
Loading

@AllanZyne AllanZyne marked this pull request as draft May 6, 2024 07:45
fschlimb
fschlimb reviewed May 16, 2024
View reviewed changes
@AllanZyne AllanZyne marked this pull request as ready for review June 24, 2024 10:51
fschlimb
fschlimb requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@fschlimb fschlimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I have a few remarks.

@fschlimb fschlimb requested a review from tkarna June 25, 2024 10:58
@AllanZyne AllanZyne requested a review from fschlimb June 25, 2024 11:19
fschlimb
fschlimb approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@fschlimb fschlimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

tkarna
tkarna requested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@tkarna tkarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me, only minor comments

@AllanZyne AllanZyne requested a review from tkarna June 26, 2024 10:19
tkarna
tkarna approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@tkarna tkarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, looks good!

@fschlimb
Copy link
Contributor

@AllanZyne You need to add sharpy.random to the list of packages in setup.py:56. This will add the new random directory/package to the install.

@AllanZyne
Copy link
Collaborator Author

@AllanZyne You need to add sharpy.random to the list of packages in setup.py:56. This will add the new random directory/package to the install.

Done.

@AllanZyne
Copy link
Collaborator Author

Hi @fschlimb,
I pushed a new commit to fix crash on "test_random.py".
Can you help to rerun CI?

Thanks!

@AllanZyne
Copy link
Collaborator Author

Hi @tkarna, have your patch on "Remove temporaries pass" been merged into imex?

@tkarna
Copy link
Collaborator

tkarna commented Jun 28, 2024

Hi @tkarna, have your patch on "Remove temporaries pass" been merged into imex?

Yes. But it looks like imex_version.txt still points to an earlier version without the fix. You should update it. The latest sha is intel/mlir-extensions@a02f093

tkarna
tkarna approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@tkarna tkarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fschlimb fschlimb merged commit 361dc2b into IntelPython:main Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschlimb fschlimb fschlimb approved these changes

@tkarna tkarna tkarna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AllanZyne @fschlimb @tkarna