Skip to content
This repository was archived by the owner on Jan 26, 2026. It is now read-only.

Update ci.yml#1

Merged
fschlimb merged 15 commits into
mainfrom
actions
Apr 15, 2024
Merged

Update ci.yml#1
fschlimb merged 15 commits into
mainfrom
actions

Conversation

@fschlimb

@fschlimb fschlimb commented Apr 10, 2024

Copy link
Copy Markdown
Contributor

@fschlimb fschlimb requested a review from tkarna April 11, 2024 16:12

@tkarna tkarna left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread conda-recipe/build.sh
Comment on lines +33 to +51
# grrrr
# as long as the conda packages differ from system oneAPI installs we need to explicitly provide the include dir for SYCL
# see also below in cmake call
# for root in "${CONDA_PREFIX}" "${BUILD_PREFIX}"; do
# spirvdir=$(find "${root}" -type d -name __spirv | head -n 1)
# if [ -d "${spirvdir}" ]; then
# SPIRV_INC_DIR=$(dirname "${spirvdir}")
# break
# fi
# done
# if [ -d "${SPIRV_INC_DIR}" ]; then
# echo "Using SPIRV_INC_DIR=${SPIRV_INC_DIR}"
# mkdir -p "${SRC_DIR}/grrrr/include"
# ln -s "${SPIRV_INC_DIR}" "${SRC_DIR}/grrrr/include/CL"
# SPIRV_INC_DIR="${SRC_DIR}/grrrr/include"
# else
# echo "Fatal error: SPIRV_INC_DIR not found"
# exit 1
# fi

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm comments?

Comment thread conda-recipe/build.sh
Comment on lines +98 to +101
# -DLEVEL_ZERO_DIR=${INSTALLED_DIR}/level-zero \
# -DIMEX_ENABLE_SYCL_RUNTIME=1 \
# -DIMEX_ENABLE_L0_RUNTIME=1 \
# -DCMAKE_CXX_FLAGS="-I${SPIRV_INC_DIR}" # grrrr

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm comments?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind I'll keep the comments for later when we enable oneAPI/devices.

@fschlimb fschlimb merged commit b0c02fc into main Apr 15, 2024
@fschlimb fschlimb deleted the actions branch April 15, 2024 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants