Add getter for NumPy ufunc types to patching#226
Open
ndgrigorian wants to merge 1 commit into
Open
Conversation
NumPy 2.5+ changed how types property is exposed in NumPy, causing indexing on the types to break also fixes a bug where patching would attempt to free null pointers when patching process fails midway
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
antonwolfy
reviewed
Jun 12, 2026
| free(self.functions) | ||
| if self.functions is not NULL: | ||
| for i in range(self.functions_count): | ||
| free(self.functions[i].signature) |
Collaborator
There was a problem hiding this comment.
It might be NULL when nargs == 0
|
|
||
| self.functions = <function_info *> malloc( | ||
| self.functions_count * sizeof(function_info) | ||
| expected_count * sizeof(function_info) |
Collaborator
There was a problem hiding this comment.
Do we need to call malloc only when expected_count > 0?
|
|
||
| cnp.import_umath() | ||
|
|
||
| cdef extern from *: |
Collaborator
There was a problem hiding this comment.
Need to populate the chnagelog
| @@ -53,66 +63,74 @@ cdef class _patch_impl: | |||
| functions_dict = dict() | |||
Collaborator
There was a problem hiding this comment.
Should it be an instance attribute instead of class-level one?
cdef dict functions_dict
In that case each _patch_impl instance owns its own mapping and it's freed with the instance (more robust approach).
But we need to add initialization to the cinit below:
def __cinit__(self):
self.functions_dict = {}
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy 2.5 has changed how types property is exposed with
ufunc.types. This caused mkl_umath to crash during patching on pre-release NumPy.This PR adds a getter,
_get_ufunc_types, defined in_patch_numpy.pyxas cdef extern. This getter works with NumPy 2.5 and previous versions by accessing the ufunc struct directly.Additionally, slips in changes which prevent attempting free of nullptr when the patch fails (i.e., due to RuntimeError).