-
Notifications
You must be signed in to change notification settings - Fork 20
add an interface for dask.fft
#214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8e78150 to
90578c9
Compare
90578c9 to
647d164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new Dask interface for the mkl_fft package, providing a drop-in replacement for the dask.fft module that leverages Intel MKL's optimized FFT implementations.
- Implements
mkl_fft.interfaces.dask_fftmodule with all FFT functions wrapped using Dask'sfft_wrap - Adds comprehensive test suite for the new Dask interface functionality
- Updates build configuration and documentation to support the new interface
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Adds dask_interface optional dependency and includes dask in test dependencies |
| mkl_fft/interfaces/dask_fft.py | New module implementing Dask FFT interface by wrapping numpy_fft functions |
| mkl_fft/tests/third_party/dask/test_dask_fft.py | Comprehensive test suite for Dask FFT functionality |
| mkl_fft/tests/test_interfaces.py | Updates interface tests to include Dask FFT |
| mkl_fft/interfaces/init.py | Conditionally imports dask_fft module when Dask is available |
| mkl_fft/interfaces/README.md | Adds documentation for the new Dask interface |
| conda-recipe/meta.yaml | Updates conda recipe to include dask test dependency and import test |
| conda-recipe-cf/meta.yaml | Updates conda-forge recipe similarly |
| CHANGELOG.md | Documents the new Dask interface feature |
| .github/workflows/*.yml | Updates CI workflows to include dask as test dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jharlow-intel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some conflicts need to be resolved.
It's okay that the 3.14 internal CI is broken for now, though
address #5