Skip to content

update pyproject.toml #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

update pyproject.toml #148

merged 3 commits into from
Apr 9, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 9, 2025

In this PR,

  1. mkl-devel is added to required packages for build.
  2. mkl is removed from dependency at run time (mkl-service is already included which depends on mkl and so mkl-service automatically installs mkl)
  3. changes are made to avoid SetuptoolsDeprecationWarning visible when --verbose is used with pip install -e .
Click to see deprecated warning /home/runner/miniconda3/envs/test/lib/python3.11/site-packages/setuptools/config/_apply_pyprojecttoml.py:82: SetuptoolsDeprecationWarning: `project.license` as a TOML table is deprecated !!
      ********************************************************************************
      Please use a simple string containing a SPDX expression for `project.license`. You can also use `project.license-files`. (Both options available on setuptools>=77.0.0).

      By 2026-Feb-18, you need to update your project and remove deprecated calls
      or your builds will no longer be supported.

      See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
      ********************************************************************************

!!
corresp(dist, value, root_dir)
/home/runner/miniconda3/envs/test/lib/python3.11/site-packages/setuptools/config/_apply_pyprojecttoml.py:61: SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!

      ********************************************************************************
      Please consider removing the following classifiers in favor of a SPDX license expression:

      License :: OSI Approved

      See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
      ********************************************************************************

!!
dist._finalize_license_expression()
/home/runner/miniconda3/envs/test/lib/python3.11/site-packages/setuptools/dist.py:759: SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!

      ********************************************************************************
      Please consider removing the following classifiers in favor of a SPDX license expression:

      License :: OSI Approved

      See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
      ********************************************************************************
  1. as part of getting rid of deprecated warning in No. 3, setuptools should be >=77.0.0.

@vtavana vtavana self-assigned this Apr 9, 2025
@vtavana vtavana marked this pull request as ready for review April 9, 2025 05:32
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, LGTM

@vtavana vtavana merged commit 1154d24 into master Apr 9, 2025
49 checks passed
@vtavana vtavana deleted the update_toml branch April 9, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants