Skip to content

Add config option to run model over validation set #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dxoigmn wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add config option to run model over validation set #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c110c9
Add option to run model over validation set
dxoigmn Jul 20, 2023
d329a79
style
dxoigmn Jul 20, 2023
991e8f8
Default validate to false
dxoigmn Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mart/configs/lightning.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ tags: ["dev"]
# Train it or not.
fit: True

# check performance on test set, using the best model achieved during training
# check performance on validation and test set, using the best model achieved during training
# lightning chooses best model based on metric specified in checkpoint callback
validate: False
test: True

# Whether to resume training using configuration and checkpoint in specified directory
Expand Down
5 changes: 5 additions & 0 deletions mart/tasks/lightning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ def lightning(cfg: DictConfig) -> Tuple[Dict[str, Any], Dict[str, Any]]:

train_metrics = trainer.callback_metrics

# Evaluate model on validation set, using the best model achieved during training
if cfg.get("validate"):
log.info("Starting validation!")
trainer.validate(model=model, datamodule=datamodule, ckpt_path=ckpt_path)

# Evaluate model on test set, using the best model achieved during training
if cfg.get("test"):
log.info("Starting testing!")
Expand Down