Skip to content

feat: enable/disable auto masking screenshots in rn #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 20, 2025
Merged

feat: enable/disable auto masking screenshots in rn #1389

merged 15 commits into from
May 20, 2025

Conversation

AyaMahmoud148
Copy link
Contributor

Description of the change

Re-merge [RN] enabiling/disabling RN screenshot auto masking

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@AyaMahmoud148 AyaMahmoud148 changed the base branch from master to dev May 14, 2025 10:52
@AyaMahmoud148 AyaMahmoud148 changed the title Rn/enabling/disbaling screenshot auto masking feat: enable/disable auto masking screenshots in rn May 14, 2025
@InstabugCI
Copy link
Collaborator

InstabugCI commented May 14, 2025 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 95.1% ✅
Android 50.9% ✅
iOS 51.5% ✅

Generated by 🚫 dangerJS against c9b85d3

ahmedAlaaInstabug
ahmedAlaaInstabug requested changes May 15, 2025
View reviewed changes
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job,, we just need to add JS unit tests for enableAutoMasking method

@kholood-ea kholood-ea enabled auto-merge (squash) May 20, 2025 13:20
@kholood-ea kholood-ea merged commit 94b5e5b into dev May 20, 2025
10 of 11 checks passed
@kholood-ea kholood-ea deleted the RN/Enabling/disbaling-screenshot-auto-masking branch May 20, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kholood-ea kholood-ea kholood-ea approved these changes

@MoKamall MoKamall MoKamall approved these changes

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@AndrewAminInstabug AndrewAminInstabug Awaiting requested review from AndrewAminInstabug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AyaMahmoud148 @InstabugCI @kholood-ea @MoKamall @ahmedAlaaInstabug