Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Remove the ITK_USE_CONCEPT_CHECKING option #5164

Conversation

sbelsk
Copy link
Contributor

@sbelsk sbelsk commented Jan 23, 2025

Resolves #3775. These changes remove the ITK_USE_CONCEPT_CHECKING option in favor of always performing concept checking, since this option has been enabled by default for a while now.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

@github-actions github-actions bot added the type:Enhancement Improvement of existing methods or implementation label Jan 23, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing a pull request! 🙏

Welcome to the ITK community! 🤗👋☀️

We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
More support and guidance on the contribution process can be found in our contributing guide. 📖

This is an automatic message. Allow for time for the ITK community to be able to read the pull request and comment
on it.

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look thoroughly, but it looks good.

@seanm
Copy link
Contributor

seanm commented Jan 23, 2025

What about ITK_USE_STRICT_CONCEPT_CHECKING?

@dzenanz
Copy link
Member

dzenanz commented Jan 23, 2025

That was already removed:

"Compilers requiring ITK_USE_STRICT_CONCEPT_CHECKING are no longer supported. This variable is no longer used.")

@seanm
Copy link
Contributor

seanm commented Jan 23, 2025

OK great! I noticed my cdash scripts had both, so I'll remove both from my scripts.

@hjmjohnson hjmjohnson merged commit 9e582fd into InsightSoftwareConsortium:master Jan 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement Improvement of existing methods or implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove option ITK_USE_CONCEPT_CHECKING
4 participants