Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: fixed issue 4818 with itkMemoryProbesCollecterBaseTest #5152

Merged

Conversation

seanm
Copy link
Contributor

@seanm seanm commented Jan 23, 2025

On macOS, itkMemoryProbesCollecterBaseTest would often fail with messages like:

Freeing memory should result in less memory but it is 262216kB instead of 262164kB

Just increased the amout of memory allocated in this test to make it more likely to pass.

Closes #4818.

On macOS, itkMemoryProbesCollecterBaseTest would often fail with messages like:

Freeing memory should result in less memory but it is 262216kB instead of 262164kB

Just increased the amout of memory allocated in this test to make it more likely to pass.
@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module labels Jan 23, 2025
@seanm seanm requested a review from dzenanz January 23, 2025 18:21
@hjmjohnson hjmjohnson merged commit 524df2a into InsightSoftwareConsortium:master Jan 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the itkMemoryProbesCollecterBaseTest useful? It fails on macOS, at least in some conditions
3 participants