Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix Py_LIMITED_API minor version spec #4589

Merged

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Apr 15, 2024

This is in hex, we want 11 in decimal.

Ref:

https://docs.python.org/3/c-api/apiabiversion.html#c.PY_VERSION_HEX

@thewtex thewtex requested a review from phcerdan April 15, 2024 19:41
@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances area:Python wrapping Python bindings for a class labels Apr 15, 2024
Copy link
Contributor

@phcerdan phcerdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👀

@thewtex thewtex merged commit 2082a93 into InsightSoftwareConsortium:master Apr 16, 2024
13 of 14 checks passed
@thewtex thewtex deleted the py-limited-minor-version branch April 16, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Python wrapping Python bindings for a class type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants