Doc update - example on carmaker fixed #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… decoding are options too
|
I'll try to have a look today afternoon or tomorrow |
|
@hadrilec I'm having a look now, in the meantime, could add |
tfardet
requested changes
Feb 17, 2025
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "data.to_csv('sirene.csv')" | ||
| "init_conn(sirene_key='f7345356-8301-4567-b453-568301456723')" |
There was a problem hiding this comment.
Should that really be there?
There was a problem hiding this comment.
indeed, big mistake I will have to delete the PR
There was a problem hiding this comment.
no, you have to reset the key, the data is leaked already ;)
the PR can stay, your key has to change ^^
Comment on lines
+229
to
+230
| " else:\n", | ||
| " return pattern[0]" |
There was a problem hiding this comment.
you can use a return early pattern, here: drop the else line and just keep return pattern[0]
Comment on lines
+219
to
+222
| " match_list = ['RENAULT SAS', 'ALPINE', 'BATILLY', 'MAUBEUGE CONSTRUCTION',\n", | ||
| " 'TOYOTA', 'STELLANTIS AUTO SAS', 'RENAULT TRUCKS']\n", | ||
| " \n", | ||
| " values = ['RENAULT SAS', 'RENAULT SAS', 'RENAULT SAS', 'RENAULT SAS',\n", |
There was a problem hiding this comment.
use a dictionary instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example on carmaker fixed