Skip to content

bugfix - import object instead of module #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2023
Merged

Conversation

hadrilec
Copy link
Contributor

@hadrilec hadrilec commented Sep 2, 2023

No description provided.

@tfardet
Copy link
Collaborator

tfardet commented Sep 4, 2023

Ah, yeah, I'm the one who introduced this bug... there is still two imports missing in test_pynsee_geodata/sirene.py.
Sorry about that! Don't know why it did not appear in the tests, nor on my local machine...
I did not expect the module to take precedence over the object when they have the same name, this really makes it a pain to manage imports...

EDIT: to be honest, given that strange bug (as far as I understand, this is not supposed to happen), I think the naming pattern in pynsee is detrimental and I would propose to rename GeoFrDataFrame.py to something else to avoid this kind of issue.
More generally, this should probably progressively be done for the whole library whenever we have the occasion.
I'll open an issue about that.

EDIT 2: see #174

@tfardet
Copy link
Collaborator

tfardet commented Sep 5, 2023

Wait, @hadrilec I just noticed that CI is checking master instead of the latest PR commit.

I don't know why we need checkout but if we use it, maybe this is what we need? https://github.com/actions/checkout#checkout-pull-request-head-commit-instead-of-merge-commit

@hadrilec hadrilec merged commit b15818b into master Sep 9, 2023
@hadrilec hadrilec deleted the bugfix-geofrdataframe branch December 27, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants