Skip to content

template list: PROJECTS and SUCCESS columns from the catalog's current fields - #170

Merged
Fermionic-Lyu merged 1 commit into
mainfrom
claude/template-catalog-fields
Sep 2, 2026
Merged

template list: PROJECTS and SUCCESS columns from the catalog's current fields#170
Fermionic-Lyu merged 1 commit into
mainfrom
claude/template-catalog-fields

Conversation

@Fermionic-Lyu

@Fermionic-Lyu Fermionic-Lyu commented Sep 2, 2026

Copy link
Copy Markdown
Member

Pairs with InsForge/insta-platform#365 (merged), which removed the catalog's deprecated fields with no compatibility period.

  • insta template list: the VARS and DEPLOYS columns read requiredVarCount and deployCount, which the list no longer serves (and deployCount counted projects under a deployments name), so both printed 0 on every row. They become PROJECTS (totalProjects) and SUCCESS (successRate as a whole percent; - while nothing has concluded — the platform sends null, never 0, for that).
  • missingVariablesFrom reads the 400 body's missing only; the missingVariables alias is gone from the platform.
  • TemplateIndexEntry carries the fields the list serves (maintainer, totalProjects, successRate).

Gate: typecheck and the full vitest suite pass.


Summary by cubic

Fixes insta template list to use the catalog's current fields after the platform removed the deprecated ones, so the table no longer prints 0 for every row.

  • VARS and DEPLOYS columns become PROJECTS (totalProjects) and SUCCESS (successRate as a whole percent; shows - while nothing has concluded, since the platform sends null).
  • missingVariablesFrom now reads only the 400 body's missing field; the missingVariables alias is gone from the platform.
  • TemplateIndexEntry carries maintainer, totalProjects, and successRate instead of the removed counts.

Migration

  • Requires the platform change in InsForge/insta-platform#365, which removed the deprecated fields with no compatibility period.

Written for commit 5422a49. Summary will update on new commits.

Review in cubic

…t fields

The platform dropped requiredVarCount and deployCount from the list (the latter counted projects
under a deployments name) and the missingVariables alias from the 400 body; the table shows
totalProjects and successRate, and the missing-variables reply is read from `missing`.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@agent-zhang-beihai agent-zhang-beihai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Yang Dong

This updates template listings to show the catalog’s current project count and success rate, and aligns missing-variable handling with the current response shape. The change is focused and correct, so I approve it.

No findings.

@agent-zhang-beihai agent-zhang-beihai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Wang Miao

This repoints insta template list at the two fields the catalog actually serves — totalProjects and the nullable successRate — replacing VARS/DEPLOYS, which the platform stopped sending and which therefore printed 0 on every row, and drops the missingVariables alias the 400 body never carries. I checked the platform's catalog builder and its missing_variables responder, and both match what the CLI now reads; the - for null is the right rendering since the platform documents null, never 0, for "nothing concluded". Approving.

No findings.

Evidence

read-the-codesrc/commands/template.ts:16-38,163-173, test/template.test.ts:205-217,326-336; insta-platform (default branch, read-only clone): src/provisioning/templates.ts:118-125,300-390 (entry built with totalProjects/successRate, no requiredVarCount/deployCount), src/openapi/schemas/common.ts:1047-1075 (TemplateListItem), src/server.ts:2640,2687 ({ error: 'missing_variables', missing: [...] } only), test/template-executor.test.ts:1510-1511 (list asserts not.toHaveProperty('deployCount')); insta-oss serves no /templates route, so the CLI's only server for this command is the platform. Column padding for both fixture rows recomputed by hand against the asserted strings.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@jwfing jwfing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - approved.

@Fermionic-Lyu
Fermionic-Lyu merged commit 73a3d0d into main Sep 2, 2026
3 checks passed
@Fermionic-Lyu
Fermionic-Lyu deleted the claude/template-catalog-fields branch September 2, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants