Fix user tile bug #545
Merged
Fix user tile bug #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rrrutledge
commented
Mar 29, 2023
•
rrrutledge
commented
- For some reason, some author objects in the graph API are missing a user object (and subsequently a user URL).
- Users without a URL don't get a link to their GitHub profile.
- Fix is to explicitly ensure that we don't overwrite a good user URL with an empty one.
- See yasakawa user tile should link to github profile #536
* For some reason, some user objects in the graph API are missing a user URL. * Users without a URL don't get a link to their GitHub profile. * Fix is to explicitly ensure that we don't overwrite a good user URL with an empty one.
|
A better fix would be to figure out why some author objects in the API are getting returned without a user, but I couldn't see how to make much headway, there. |
nysenthil
approved these changes
Apr 4, 2023
|
This morning, I discussed this PR with Russ to go over his code changes. All looks good. I'm approving and merging this PR now. |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.