Bz1829448 multiple address families for mac #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to commit 137286e a config would not be considered in context if: a) it has no address family flags set b) it has the address family flag of current context set Since above commit config is considered in context if the address family is the opposite of current context. The result is that a config with two dhcp-host records, one for IPv6 and another for IPv4 no longer works, for example with the below config the config with the IPv6 address would be considered in context for a DHCP(v4) request. dhcp-host=52:54:00:bc:c3:fd,172.20.0.11,host2 dhcp-host=52:54:00:bc:c3:fd,[fd12:3456:789a:1::aadd],host2 This commit restores the previous behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora BZ
upstream thread