Skip to content

feat: support-basic-env #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2025
Merged

feat: support-basic-env #137

merged 5 commits into from
May 7, 2025

Conversation

NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented May 6, 2025

Closes #

Proposed Changes

  • Add support for environment variables with the same name as in other clients

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.50%. Comparing base (099b9f6) to head (4e9c593).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   61.90%   62.50%   +0.60%     
==========================================
  Files          33       33              
  Lines        2134     2163      +29     
==========================================
+ Hits         1321     1352      +31     
+ Misses        813      811       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96 NguyenHoangSon96 requested a review from jansimonb May 6, 2025 09:37
@NguyenHoangSon96 NguyenHoangSon96 requested review from jansimonb and removed request for jansimonb May 7, 2025 08:33
Copy link
Contributor

@jansimonb jansimonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@NguyenHoangSon96 NguyenHoangSon96 merged commit 7d5952f into main May 7, 2025
14 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the feat/support-basic-env branch May 7, 2025 09:34
@karel-rehor karel-rehor added this to the 0.13.0 milestone May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants