Skip to content

feat: support grpc options #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Apr 22, 2025

Closes #

Proposed Changes

  • Allows setting gRPC options to be passed on. Looks like the C # library does not support a lot of options like other libraries
  • Not sure why codecov complains, I already test that line 100 in FlightSqlClient and coverage more than 80% 🤷

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (4474059) to head (1c9d9c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   96.58%   96.64%   +0.05%     
==========================================
  Files          16       17       +1     
  Lines        1319     1340      +21     
  Branches      179      179              
==========================================
+ Hits         1274     1295      +21     
  Misses          4        4              
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Apr 24, 2025
@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as draft April 24, 2025 10:37
@NguyenHoangSon96 NguyenHoangSon96 changed the title Feat/support grpc options feat: support grpc options Apr 25, 2025
@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as ready for review April 25, 2025 03:52
@jansimonb
Copy link
Contributor

Line 100 is tested partially because of the QueryOptions?.Deadline construct, where QueryOptions can be either null or not null..

@NguyenHoangSon96 NguyenHoangSon96 requested a review from jansimonb May 2, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants