Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type of get_encoding_tableau #209

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix return type of get_encoding_tableau #209

merged 2 commits into from
Jan 29, 2025

Conversation

vtomole
Copy link
Member

@vtomole vtomole commented Jan 29, 2025

I wonder why the type checker doesn't catch this. 🤔

@vtomole vtomole requested a review from perlinm as a code owner January 29, 2025 19:21
perlinm
perlinm approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@perlinm perlinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Yeah, curious why it wasn't caught...

@perlinm perlinm merged commit 1918b0c into main Jan 29, 2025
4 checks passed
@perlinm perlinm deleted the vtomole-patch-1 branch January 29, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perlinm perlinm perlinm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtomole @perlinm