-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/xeb implementation #993
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
380bfd4
to
47e1c8b
Compare
47e1c8b
to
fd3307a
Compare
fd3307a
to
7187d83
Compare
e71d21b
to
7cd799c
Compare
e678bc4
to
77e4262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nits
@@ -0,0 +1,349 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,349 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,349 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,349 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #2. single_qubit_experiment.prepare_experiment(num_circuits=25, cycle_depths=[10, 50, 100, 200])
nit: keyword argument for readability
Reply via ReviewNB
@@ -0,0 +1,349 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #9. print(f"Two qubit depolarising error: {two_qubit_depolarising_error:4f}")
nit: float formatting
Reply via ReviewNB
@@ -0,0 +1,349 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #10. print(f"Estimated two qubit depolarising error: {two_qubit_depolarising_error_estimate:.4f}")
nit: float formatting
Reply via ReviewNB
Implement the XEB routine within the QCVV experiment framework.
Blocked by #992