DisplayApp: Return to the clock when sleeping from a notification preview - #2474
Open
JoeStrout wants to merge 1 commit into
Open
DisplayApp: Return to the clock when sleeping from a notification preview#2474JoeStrout wants to merge 1 commit into
JoeStrout wants to merge 1 commit into
Conversation
…view When the display goes to sleep, DisplayApp returns to the clock face from every transient screen except the notification preview. A preview that has been tapped once has already cancelled its auto-close timer and released its wake lock, so it stays loaded across sleep and reappears on every wake until you navigate away from it manually. Add Apps::NotificationsPreview to the list of screens that are left behind on sleep, so a tapped preview is dismissed like every other transient screen.
JoeStrout
marked this pull request as ready for review
August 14, 2026 17:56
|
Build size and comparison to main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the display goes to sleep,
DisplayApp::Refresh()returns to the clock face from every transient screen except the notification preview. A preview that has been tapped once has already cancelled its auto-close timer and released its wake lock, so it stays loaded across sleep and reappears on every wake until you navigate away from it manually.This adds
Apps::NotificationsPreviewto the list of screens that are left behind on sleep, so a tapped preview is dismissed like every other transient screen.To reproduce: send a notification, tap the preview once (don't swipe it away), let the display time out, then wake the watch — the preview is still there, and stays there on every subsequent wake.
Tested on hardware (PineTime,
pinetime-app).