Skip to content

Fix OTA silently transferring a zero-length image #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fluffyspace wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix OTA silently transferring a zero-length image #2466

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c560df9
Fix OTA silently transferring a zero-length image
fluffyspace Aug 6, 2026
43feb6c
Stop the inactivity timer before the sleep-disable wait as well
fluffyspace Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/components/ble/DfuService.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,15 @@ int DfuService::WritePacketHandler(uint16_t connectionHandle, os_mbuf* om) {
bootloaderSize,
applicationSize);

// From here until the response below, this task blocks and cannot service BLE:
// first the unbounded wait for SystemTask to disable sleeping, then the image-slot
// erase, which can approach or exceed the 10s inactivity timeout (116 sectors at a
// datasheet-max 300ms each). The timer runs on the FreeRTOS timer task, so it fires
// while this task is blocked; its Reset() zeroes applicationSize, the erase then
// completes and the transfer carries on with a zero-length image. Hold the timeout
// off until this handler can react to packets again.
xTimerStop(timeoutTimer, 0);

// Wait until SystemTask has disabled sleeping
// This isn't quite correct, as we don't actually know
// if BleFirmwareUpdateStarted has been received yet
Expand All @@ -146,6 +155,7 @@ int DfuService::WritePacketHandler(uint16_t connectionHandle, os_mbuf* om) {
}

dfuImage.Erase();
xTimerStart(timeoutTimer, 0);

uint8_t data[] {16, 1, 1};
notificationManager.Send(connectionHandle, controlPointCharacteristicHandle, data, 3);
Expand Down
Loading