Add time since last weather update to weather app #2242
Conversation
JustScott
force-pushed
the
weather_time_since_last_update
branch
from
bbb52e9 to
9d13f7a
Compare
|
Build size and comparison to main:
|
src/displayapp/screens/Weather.cpp
Outdated
|
|
||
| int64_t secondsSinceEpoch = dateTimeController.CurrentDateTime().time_since_epoch().count() / 1000000000; | ||
| int64_t secondsSinceWeatherUpdate = secondsSinceEpoch - optCurrentWeather->timestamp; | ||
| if (secondsSinceWeatherUpdate < 0) { |
There was a problem hiding this comment.
Do we really need the 0 check? Unless the number of seconds somehow becomes negative, it shouldn't be necessary
There was a problem hiding this comment.
I did have it showing -1 a few times in the simulator, so figured I would add that just to cover it in the off chance it happened on the watch.
|
Personally, I would prefer to see the minutes instead of the seconds when I have recently updated my weather. For instance, instead of displaying “32 seconds old,” I would like to see “Now” and only show the number of minutes after one has passed. Another aspect that feels more natural to me is using the phrase “X minutes ago” instead of “X minutes old.” |
I agree with you on using
Have to move the label up And I move the temp up as well to prevent crowding: |
|
I like
Adding another word results in a less awkward look, as well as being more direct and intuitive to understand. |
|
In these two images the label doesn't seem to be centered. Is that just me? |
|
@tituscmd I fixed the centering issue by dynamically positioning the label depending on weather there is one or two digits. I just tried out a bunch of examples of how this could look, everyone should let me know which they prefer! With a seconds counter (with dynamic alignment)
Two version of up to date
variations of "updated now"
"Updated:" with dynamic alignment
I can make more examples if anyones curious. Just let me know. I personally prefer to just include the seconds count, as it may be useful to some and keeps the label consistent... also the live second count on hardware makes the app feel more lively. |
|
In this image, if you look at the weather icon up top it still doesn't look centered. I would suggest aligning the label with a pointer to the weather icon or the day in the middle of the table, those always seem to be centered. I may be a bit of a perfectionist ;D |
|
@JustScott Thank you so much for making all these options! I think after looking at everything, I like |
Ah I see what you mean about it not looking centered, I was just trying to keep the space between the |
I agree with you on this, but am curious as to how long you think the app should display |
I see, that makes sense. |
Oh, right. What about at |
Okay, just so anyone reading this is caught up, here's what it'll look like:
I personally prefer it to be centered over the third words second letter, so I say we see what the others think. I'm open to changing it if people agree it doesn't look centered. |
Use "Now" for the label until 31 seconds, then display the live time.
Provides the time since the last weather update, incrementing the duration from seconds to minutes at 60 seconds, and minutes to hours at 3600 seconds. I'm open to suggestions on changes to the texts position and/or color. This should resolve #2140.
Also, on the simulator the seconds old count is only updated when you open the app, while on hardware the seconds count up live while in the app... I'm not sure why this is.