fix(torch): make gemm fallback portable#611
Merged
Merged
Conversation
gemm fallback portable
fb172b6 to
7bcc2d5
Compare
7bcc2d5 to
a48c4e8
Compare
55 tasks
Collaborator
Author
|
请 @crapromer 初审,@Ziminli 终审。 |
crapromer
approved these changes
May 16, 2026
Ziminli
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gemmfallback on fusedaddmm_out/baddbmm_outfor CPU and NVIDIA, preserving their existing numerical behavior.matmulplus explicitalpha/betaupdate for other vendor PyTorch backends where fusedout=GEMM variants are unavailable or numerically inconsistent.tests/test_gemm.pyreference path so vendor fallback tests compare against the same portable execution order.Motivation
The PyTorch-backed Gemm fallback is used as a cross-platform fallback path, but some vendor PyTorch forks reject or diverge on fused
out=GEMM variants. The implementation also previously needed exception-based fallback logic, which conflicts with the project C++ rule that forbids exceptions. Keeping fused calls only where they are known to match the current baseline, and using an explicit portable path elsewhere, keeps the fallback deterministic across supported backends.Closes N/A.
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Test Results on Supported Platforms
The higher item counts compared with #610 are expected. This validation was run with the existing hand-written PyTorch C++ backend enabled (
WITH_TORCH=ONvia backend auto-detection), so the pre-existingAdd/GemmPyTorch slot is included in collection. This PR does not add new parametrized test coverage; the count increase comes from enabling that existing backend during validation.The clean full-suite validation was run on a temporary branch containing this PR plus #612, because the two fixes address independent failures that otherwise mask each other in full-platform runs.
pytestResult6295 passed, 2447 skipped in 345.48s4795 passed, 2447 skipped in 284.25s5795 passed, 1447 skipped in 361.81s3073 passed, 3857 skipped in 920.38s5759 passed, 1483 skipped in 574.92s4472 passed, 2710 skipped in 527.68s; wrapper exit code137Additional targeted validation for this PR:
Full `pytest` output (optional)
Benchmark / Performance Impact
N/A. This PR prioritizes portability of the fallback implementation; it is not intended as a performance optimization.
Notes for Reviewers
The fallback intentionally avoids C++ exceptions. CPU and NVIDIA keep the fused PyTorch path to preserve the current baseline. Other device specializations use the portable
matmulpath because several vendor PyTorch forks do not provide the same fusedout=behavior.This PR is independent from #612, but a fully clean all-platform suite currently requires both fixes: this PR removes unrelated
tests/test_gemm.pyfallback failures, while #612 removes the Iluvatartests/test_causal_softmax.pyreference failure.Checklist
Title, Branch, and Commits
feat(nvidia): …,fix(cuda/gemm): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene (applies to all languages)
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `seqlens_k` tensor) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 21, per.github/workflows/clang-format.yml) has been run against all modified.h,.cc,.cuh, and.mlufiles; the diff is clean.clang-tidyconcerns (per.clang-tidy) have been reviewed — no new warnings beyond the existing baseline.CONTRIBUTING.md§C++).assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).new/delete; RAII / smart pointers / existing allocators are used.Python Specific (if Python files changed)
ruff checkpasses cleanly on CI (see.github/workflows/ruff.yml).ruff format --checkpasses cleanly — if not, runruff formatand commit the result.CONTRIBUTING.md§Python).pytest.skipmessages without terminal period) are honored where applicable (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).if,for, and similar control-flow statements (CONTRIBUTING.md§Python).return, except when it directly follows a control-flow statement likeiforfor(CONTRIBUTING.md§Python).Testing
pytestwas run locally on every supported platform that this PR can affect, and the results are recorded in the "Test Results" table above (CONTRIBUTING.md§Pull Requests).tests/followingtests/test_add.py/tests/test_gemm.pypatterns (CONTRIBUTING.md§Adding an Operator).pytest.mark.parametrizecorrectly: dependent parameters share one decorator (e.g.@pytest.mark.parametrize("dtype, rtol, atol", …)); independent parameters use separate decorators ordered by parameter declaration.pytest.mark.auto_act_and_assertis used and the test returns aPayloadwhosefuncandrefshare the same calling convention.dtype/deviceparameterization is relied on, or overridden with an explicitpytest.mark.parametrizewhen necessary.pytest -n 1.masterand passes with this PR.Build, CI, and Tooling
pip install .[dev]on at least one affected platform.compile_commands.jsonstill regenerates (CMake optionCMAKE_EXPORT_COMPILE_COMMANDS=ONinpyproject.toml— required by thecode-lintskill andclang-tidy -p).CMakeLists.txtis not broken.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).pyproject.toml's[project.optional-dependencies](or justified in the PR description).Documentation
Security and Safety