[DEV-14516]: RetrySubmission #159
Conversation
|
@goatrocks not sure if im missing anything, mind taking a quick peek? 🙏 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| { | ||
| Status = SubmissionStatus.FAILED | ||
| }; | ||
| var failedSubmissions = await _submissionsClient.ListAsync(new List<int> { submissionId }, new List<int> { _workflowId }, filters, 0, 10); |
There was a problem hiding this comment.
shouldn't filter submissionId here
|
IndicoV2.StrawberryShake/Generated/IndicoGqlClient.StrawberryShake.cs does this need to be regenerated? |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| }; | ||
| }).ToArray() ?? Array.Empty<SubmissionRetry>() | ||
| }; | ||
| }).ToList() ?? new List<ISubmission>(); |
There was a problem hiding this comment.
Missing null checks for collection elements in Select
Medium Severity
The RetrySubmissionsAsync method iterates over result using Select without checking if individual elements are null. If the GraphQL API returns null elements in the retrySubmissions array or in the nested retries array, accessing properties like r.Status, r.Id, or retry.PreviousStatus will throw a NullReferenceException. This was flagged by the reviewer as "null reference issues" that need to be fixed.
Note
Introduces a retry capability for failed submissions across the client and GraphQL layers.
RetrySubmissionsAsync(IEnumerable<int>)toISubmissionsClientand implements it inSubmissionsClient, including argument validation and mapping ofretriesmetadataRetrySubmissionsGraphQL mutation inSubmissions.graphqland wires it viaSubmissionSsClient.Retry(...)RetriesinfoCODEOWNERSWritten by Cursor Bugbot for commit 2a489e0. This will update automatically on new commits. Configure here.