forked from openwallet-foundation/acapy
-
Notifications
You must be signed in to change notification settings - Fork 1
[pull] main from openwallet-foundation:main #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
25
commits into
Indicio-tech:main
Choose a base branch
from
openwallet-foundation:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instead of caching to the Runner FS and then uploading it, use native Docker caching to Github Actions * Run and fix `zizmor` warnings * Disable persisting git credentials * Disable caching of Buildx binary * Replace unnecessary "Gather image info" step with Github's built in `${{ github.repository_owner }}` function * Update `docker/build-push-action` from `v5` to `v6` Signed-off-by: Robbie Blaine <[email protected]>
Signed-off-by: Robbie Blaine <[email protected]>
👷 Fix Docker Caching
* Build Standard image on native CPU architectures * `linux/arm64` builds on `ubuntu-24.04-arm` (`arm64`) * `linux/amd64` builds on `ubuntu-24.04` (`x86_64`) * Split build and publish * Build docker images on native runners, don't push, cache to GHA * Combine multi-arch, read from cache, push to GHCR.io * Due to a version mismatch in buildx between `ubuntu-24.04` and `ubuntu-24.04-arm`, have to ensure the latest version of `buildx` is installed * Due to how the platforms are being handled, I've removed the `platforms` input to the workflow Signed-off-by: Robbie Blaine <[email protected]>
Signed-off-by: Robbie Blaine <[email protected]>
👷 Split Docker Builds
* 🎨 Add space to log Signed-off-by: ff137 <[email protected]> * 🎨 Remove unnecessary method (only used once) Signed-off-by: ff137 <[email protected]> * 🎨 Remove unused arg Signed-off-by: ff137 <[email protected]> * 🎨 Remove f-string formatting from logs; fix string concatenation Signed-off-by: ff137 <[email protected]> * 🐛 Add missing return statement Signed-off-by: ff137 <[email protected]> * 🎨 More removing f-string format from logs Signed-off-by: ff137 <[email protected]> * 🎨 Clarify log Signed-off-by: ff137 <[email protected]> * 🐛 Fix: return public_did_info. Resolves #3645 Signed-off-by: ff137 <[email protected]> * 🎨 Clean up `_initialize_with_public_did` method. Rename to `_replace_public_did_if_seed_mismatch` for clarity, and simplify logic Signed-off-by: ff137 <[email protected]> * 🎨 None safety Signed-off-by: ff137 <[email protected]> * 🎨 Remove extra space Signed-off-by: ff137 <[email protected]> * 🎨 Remove log method and just call directly Signed-off-by: ff137 <[email protected]> * 🐛 Add missing return statement Signed-off-by: ff137 <[email protected]> * ✅ Expand test coverage for wallet config Signed-off-by: ff137 <[email protected]> --------- Signed-off-by: ff137 <[email protected]>
Signed-off-by: Robbie Blaine <[email protected]>
* 🎨 Use revocation_anoncreds tag title Signed-off-by: ff137 <[email protected]> * 🎨 Deduplicate tag titles Signed-off-by: ff137 <[email protected]> * 🎨 Deduplicate tag titles Signed-off-by: ff137 <[email protected]> * 🎨 Avoid circular import, due to knot between anoncreds/routes and revocation_anoncreds/routes Signed-off-by: ff137 <[email protected]> * 🎨 Fix new lines in description summary Signed-off-by: ff137 <[email protected]> * 📝 Update openapi spec Signed-off-by: ff137 <[email protected]> * 🎨 Reword update description Signed-off-by: ff137 <[email protected]> --------- Signed-off-by: ff137 <[email protected]> Co-authored-by: Stephen Curran <[email protected]>
* ✅ Correctly tear down ClientSession in TestAdminServer Signed-off-by: ff137 <[email protected]> * 🎨 Ignore create_did_document deprecation warning in test run Signed-off-by: ff137 <[email protected]> * 🧪 async test fixtures should use pytest_asyncio.fixture Signed-off-by: ff137 <[email protected]> * 🎨 Add missing pytest.mark.asyncio Signed-off-by: ff137 <[email protected]> * 🎨 Ignore create_did_document deprecation warning in test run Signed-off-by: ff137 <[email protected]> --------- Signed-off-by: ff137 <[email protected]> Co-authored-by: Stephen Curran <[email protected]>
* 🎨 Add type hints Signed-off-by: ff137 <[email protected]> * 🎨 Add todo comments. #3651 Signed-off-by: ff137 <[email protected]> * 🎨 Add return types Signed-off-by: ff137 <[email protected]> --------- Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Bumps [markdown](https://github.com/Python-Markdown/markdown) from 3.7 to 3.8. - [Release notes](https://github.com/Python-Markdown/markdown/releases) - [Changelog](https://github.com/Python-Markdown/markdown/blob/master/docs/changelog.md) - [Commits](Python-Markdown/markdown@3.7...3.8) --- updated-dependencies: - dependency-name: markdown dependency-version: '3.8' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jamshale <[email protected]>
* 🎨 Make ledger config more readable Signed-off-by: ff137 <[email protected]> * 🎨 Fix `write_ledger_set` checking all configs Signed-off-by: ff137 <[email protected]> * ✅ Fix expected error message `No writable ledger configured` instead of `No is_write ledger set` Signed-off-by: ff137 <[email protected]> * 🎨 Add logging to ledger arg parse Signed-off-by: ff137 <[email protected]> * 🎨 Clarify single_configured, multi_configured Signed-off-by: ff137 <[email protected]> * 🎨 Signed-off-by: ff137 <[email protected]> * 🎨 Reduce duplication and complexity Signed-off-by: ff137 <[email protected]> * 🎨 Add logging to `get_write_ledger_config_for_profile`, and simplify key reading Signed-off-by: ff137 <[email protected]> * 🎨 Signed-off-by: ff137 <[email protected]> * 🎨 Reduce complexity in binding multi-ledger provider Signed-off-by: ff137 <[email protected]> --------- Signed-off-by: ff137 <[email protected]>
* fix for inline VMs Signed-off-by: George Mulhearn <[email protected]> * Signed-off-by: George Mulhearn <[email protected]> * retrigger CI Signed-off-by: George Mulhearn <[email protected]> --------- Signed-off-by: George Mulhearn <[email protected]> Co-authored-by: George Mulhearn <[email protected]>
* 🎨 Rename did:indy create/response schema objects Signed-off-by: ff137 <[email protected]> * 🎨 Add more detail to options description Signed-off-by: ff137 <[email protected]> * 🎨 Clarify defaults Signed-off-by: ff137 <[email protected]> --------- Signed-off-by: ff137 <[email protected]> Co-authored-by: Stephen Curran <[email protected]>
Bumps [packaging](https://github.com/pypa/packaging) from 24.2 to 25.0. - [Release notes](https://github.com/pypa/packaging/releases) - [Changelog](https://github.com/pypa/packaging/blob/main/CHANGELOG.rst) - [Commits](pypa/packaging@24.2...25.0) --- updated-dependencies: - dependency-name: packaging dependency-version: '25.0' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…3668) Signed-off-by: StepSecurity Bot <[email protected]>
Flattens duplication by specifying "directories". Adds `/scenarios` directory to pip and docker management Signed-off-by: ff137 <[email protected]>
Signed-off-by: StepSecurity Bot <[email protected]> Co-authored-by: Stephen Curran <[email protected]>
* 🔒 Update Token Permissions in GitHub Actions Signed-off-by: ff137 <[email protected]> * 🔒 Move packages: write permission to job level Signed-off-by: ff137 <[email protected]> --------- Signed-off-by: ff137 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )