Skip to content

Fixed numerous compiler warnings #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed numerous compiler warnings #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/MQTT.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ namespace MQTT {
case SUBSCRIBE:
case UNSUBSCRIBE:
buf[bufpos] |= 0x02;
break;
default:
break;
}
bufpos++;

Expand Down Expand Up @@ -343,6 +346,10 @@ namespace MQTT {
return nullptr;

break;

default:
break;

}
}

Expand Down Expand Up @@ -486,7 +493,8 @@ namespace MQTT {
Publish::Publish(String topic, const __FlashStringHelper* payload) :
Message(PUBLISH),
_topic(topic),
_payload_len(strlen_P((PGM_P)payload)), _payload(new uint8_t[_payload_len + 1]),
_payload(new uint8_t[_payload_len + 1]),
_payload_len(strlen_P((PGM_P)payload)),
_payload_mine(true)
{
strncpy_P((char*)_payload, (PGM_P)payload, _payload_len);
Expand Down Expand Up @@ -519,8 +527,9 @@ namespace MQTT {
Publish::Publish(String topic, payload_callback_t pcb, uint32_t length) :
Message(PUBLISH),
_topic(topic),
_payload(nullptr),
_payload_len(length),
_payload(nullptr), _payload_mine(false)
_payload_mine(false)
{
_payload_callback = pcb;
}
Expand Down Expand Up @@ -599,6 +608,7 @@ namespace MQTT {
case 2:
return PUBREC;
}
return None;
}


Expand Down
3 changes: 3 additions & 0 deletions src/PubSubClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ void PubSubClient::_process_message(MQTT::Message* msg) {

case MQTT::PINGRESP:
pingOutstanding = false;

default:
break;
}
}

Expand Down
16 changes: 8 additions & 8 deletions src/PubSubClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,21 @@ class PubSubClient {
typedef void(*callback_t)(const MQTT::Publish&);
#endif

private:
IPAddress server_ip;
String server_hostname;
uint16_t server_port;
private:
callback_t _callback;

Client &_client;
MQTT::PacketParser _parser;
uint16_t nextMsgId, keepalive;
uint8_t _max_retries;
bool isSubAckFound;
IPAddress server_ip;
uint16_t server_port;
String server_hostname;

uint16_t nextMsgId, keepalive;
unsigned long lastOutActivity;
unsigned long lastInActivity;
bool pingOutstanding;
bool isSubAckFound;


//! Receive a message from the client
/*!
\return Pointer to message object, nullptr if no message has been received
Expand Down