-
Notifications
You must be signed in to change notification settings - Fork 0
Make PCA projection reproducible given seed #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NetZissou
wants to merge
2
commits into
main
Choose a base branch
from
fix/pca-seed-reproducibility
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@egrace479 very interesting comment it made here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to have corrected the
26.4statement to the actual release of26.04but then fallen back to semver to say well this clearly should be fine since 26.4 would come after 26.08 😵💫There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Experiment
max pairwise diff across 3 seeded runs, seed 614, 2000×768 danaus embeddings, A100 on ascend
I think this concludes that, when using
cumlfor t-SNE, to have reproducible resultcuml >= 26.8ANDsolver = fftI was surprised that the
exactsolver wasn't reproducing on these two versions...However, the
fftsolver has the same collapsing issue that we encountered earlier #40Conclusion
I don't think currently the backend
cumlhas a t-SNE solver that's both reproducible & collapse-free.Bump the
cumlrequirement to26.08I'd leave the solver for
cumlunchanged, fixed atexactto prevent collapsing on homogenous embeddings. Document the irreproducibility, direct the tosklearnfor reproducible results.