feat(): fix circular and linear progress values in Safari#2269
Open
adrianptrv wants to merge 4 commits into
Open
feat(): fix circular and linear progress values in Safari#2269adrianptrv wants to merge 4 commits into
adrianptrv wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Safari-specific issue with how progress label counters are computed/rendered by adjusting the registered custom property types and ensuring integer values are fed into CSS counters.
Changes:
- Register
--_progress-integer/--_progress-fractionas<number>instead of<integer>via@property. - Ensure
counter-resetreceives integer values by wrapping the custom properties withround(down, …, 1)in both linear and circular progress themes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/styles/themes/base/_theme.scss |
Updates registered custom property syntax for progress counters to <number>. |
src/components/progress/themes/linear/linear.progress.base.scss |
Uses round(down, …, 1) to provide valid integer values to counter-reset in Safari. |
src/components/progress/themes/circular/circular.progress.base.scss |
Applies the same counter-reset rounding strategy for circular progress counters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17210
Same changes as in: #17362
Type of Change
Checklist