fix(igx-ts-legacy): update igx ts legacy templates#1517
fix(igx-ts-legacy): update igx ts legacy templates#1517
Conversation
| @@ -3,7 +3,7 @@ import { routes } from "../app-routing.module"; | |||
|
|
|||
| @Component({ | |||
| selector: "nav-menu", | |||
There was a problem hiding this comment.
we should add standalone: false for all components here.
There was a problem hiding this comment.
Oh, ig-ts project shouldn't be updated at all. IIRC it's slated for removal instead
There was a problem hiding this comment.
Angular are adding now "prettier": "^3.8.1" and also are moving to "vitest": "^4.0.8". Should we do this too now?
There was a problem hiding this comment.
Vite will be added in other PR
There was a problem hiding this comment.
Angular now adds these comments to all tsconfig files
/* To learn more about Typescript configuration file: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html. */
/* To learn more about Angular compiler options: https://angular.dev/reference/configs/angular-compiler-options. */There was a problem hiding this comment.
Should we remove component from the path and class names everywhere?. If I run now ng g c home it will generate class named Home and files home.html, home.scss, home.spec.ts and home.ts. No component anywhere.
There was a problem hiding this comment.
in _base we have prettier and it is gone here. Is this correct?
There was a problem hiding this comment.
should we add prettier here too?
There was a problem hiding this comment.
Won't fix ig-ts templates
There was a problem hiding this comment.
I am not sure we need any changes in all these old migrations.
4 participants
Update igx-ts-legacy templates
Closes #1516