Skip to content

Fix toolbar dropdown positioning to prevent viewport clipping #16412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix toolbar dropdown positioning to prevent viewport clipping #16412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b21008e
Initial plan
Copilot Nov 3, 2025
8d609ca
Replace ConnectedPositioningStrategy with AutoPositionStrategy for to…
Copilot Nov 3, 2025
a4671ae
Add test to verify AutoPositionStrategy is used for toolbar dropdowns
Copilot Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion projects/igniteui-angular/src/lib/grids/grid/grid-toolbar.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component, ViewChild } from '@angular/core';
import { TestBed, fakeAsync, ComponentFixture, tick, waitForAsync } from '@angular/core/testing';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { AbsoluteScrollStrategy, GlobalPositionStrategy, IgxCsvExporterService, IgxExcelExporterService } from '../../services/public_api';
import { AbsoluteScrollStrategy, AutoPositionStrategy, GlobalPositionStrategy, IgxCsvExporterService, IgxExcelExporterService } from '../../services/public_api';
import { IgxGridComponent } from './public_api';
import { GridFunctions } from "../../test-utils/grid-functions.spec";
import { By } from "@angular/platform-browser";
Expand Down Expand Up @@ -207,6 +207,16 @@ describe('IgxGrid - Grid Toolbar #grid - ', () => {
expect(defaultExportSettings).not.toEqual(instance.exporterAction.overlaySettings);
});

it('should use AutoPositionStrategy for toolbar action dropdowns by default', () => {
const hidingSettings = instance.hidingAction.overlaySettings;
const pinningSettings = instance.pinningAction.overlaySettings;
const exporterSettings = instance.exporterAction.overlaySettings;

expect(hidingSettings.positionStrategy instanceof AutoPositionStrategy).toBe(true);
expect(pinningSettings.positionStrategy instanceof AutoPositionStrategy).toBe(true);
expect(exporterSettings.positionStrategy instanceof AutoPositionStrategy).toBe(true);
});

it('should initialize input property columnsAreaMaxHeight properly', fakeAsync(() => {
expect(instance.pinningAction.columnsAreaMaxHeight).toEqual('100%');

Expand Down
4 changes: 2 additions & 2 deletions projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar.base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { IgxColumnActionsComponent } from '../column-actions/column-actions.comp
import { IgxToggleDirective, ToggleViewCancelableEventArgs, ToggleViewEventArgs } from '../../directives/toggle/toggle.directive';
import { HorizontalAlignment, OverlaySettings, VerticalAlignment } from '../../services/overlay/utilities';
import { IgxToolbarToken } from './token';
import { ConnectedPositioningStrategy } from '../../services/overlay/position/connected-positioning-strategy';
import { AutoPositionStrategy } from '../../services/overlay/position/auto-position-strategy';

/* blazorInclude */
/* blazorElement */
Expand Down Expand Up @@ -88,7 +88,7 @@ export abstract class BaseToolbarDirective implements OnDestroy {
private $sub: Subscription;

private _overlaySettings: OverlaySettings = {
positionStrategy: new ConnectedPositioningStrategy({
positionStrategy: new AutoPositionStrategy({
horizontalDirection: HorizontalAlignment.Left,
horizontalStartPoint: HorizontalAlignment.Right,
verticalDirection: VerticalAlignment.Bottom,
Expand Down
Loading