Skip to content

feat(tooltip): align with WC tooltip #15791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from
Aug 19, 2025
Merged

feat(tooltip): align with WC tooltip #15791

merged 55 commits into from
Aug 19, 2025

Conversation

RivaIvanova
Copy link
Member

@RivaIvanova RivaIvanova commented May 12, 2025 •
edited
Loading

Closes #15726

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them tooltip labels May 12, 2025
RivaIvanova and others added 27 commits May 12, 2025 11:56
@RivaIvanova
docs(tooltip-target): update methods in readme
61e7f2f
@RivaIvanova
feat(tooltip): hover on tooltip does not close it
07eefb7
@Zneeky
feat(tooltip): Add custom close button and disable arrow functionality
aad5727
@Zneeky
Merge branch 'feature/align-tooltip' of https://github.com/IgniteUI/i…
9e27017 
…gniteui-angular into feature/align-tooltip
@Zneeky
fix(tooltip): set initially arrow to display none
a0434de
@RivaIvanova
fix(tooltip): add check for multiple targets
e647bf8
@RivaIvanova
test(tooltip): update tests with auto hide delay
d42cbd6
@RivaIvanova
fix(tooltip-close-icon): resolve circular dependency
39bb9e2
@Zneeky
feat(tooltip): add custom close button template
4923baa
@Zneeky
fix(tooltip-target): fix animation duration mistake
c5ff1bd
@RivaIvanova
feat(tooltip): add arrow, placement, offset
f6bc028
@didimmova
feat(tooltip): add arrow and close btn styles
ff9aaa5
@Zneeky
feat(tooltip): tooltip sticky functionality for multiple targets
f15008d
@Zneeky
Merge branch 'feature/align-tooltip' of https://github.com/IgniteUI/i…
16fa3f3 
…gniteui-angular into feature/align-tooltip
@Zneeky
test(tooltip): fixed minor mistake in tests
45a0570
@didimmova
feat(tooltip): update displays
ad586fa
@didimmova
style(tooltip): add width to fit content
d312fcc
@Zneeky
test(tooltip): added tests for placement and offset
f6864c9
@RivaIvanova
feat(tooltip): adjust arrow position
b7ed915
@RivaIvanova
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
8d721be 
…into feature/align-tooltip
@Zneeky
Merge branch 'feature/align-tooltip' of https://github.com/IgniteUI/i…
9f59e70 
…gniteui-angular into feature/align-tooltip
@Zneeky
test(tooltip): add tests for arrow
5f17cec
@Zneeky
refactor(tooltip): update sticky logic and add additional tests
4867e8a
@RivaIvanova
fix(tooltip): placement to bottom, no arrow by default, arrow multi t…
1a7d51a 
…argets
@RivaIvanova
fix(tooltip-sample): rename disableArrow prop
c0cffab
@Zneeky
fix(tooltip): consolidate tooltip show checks into a single method
8f6fc7a
@Zneeky
Merge branch 'feature/align-tooltip' of https://github.com/IgniteUI/i…
44270f8 
…gniteui-angular into feature/align-tooltip
@kacheshmarova kacheshmarova requested review from ChronosSF and removed request for damyanpetev and rkaraivanov August 5, 2025 12:47
@ChronosSF ChronosSF requested a review from simeonoff August 6, 2025 13:58
@ChronosSF ChronosSF added the squash-merge Merge PR with "Squash and Merge" option label Aug 6, 2025
ChronosSF
ChronosSF reviewed Aug 8, 2025
View reviewed changes
Copy link
Member

@ChronosSF ChronosSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we are doing this not to introduce a massive breaking change but it's a bit sad to see createElement and appendChild because a directive has to add DOM. If you already discussed this with @damyanpetev or @rkaraivanov , and they are okay with it, sure but I am not going to oppose making it into a component either.

CHANGELOG.md Outdated
- `IgxTooltipTarget`
- Introduced a new `positionSettings` input property. Controls the position and animation settings used by the tooltip.
- Introduced a new `sticky` input property. When set to `true`, the tooltip renders a default close icon `x`. The tooltip remains visible until the user closes it via the close icon `x` or `Esc` key. Defaults to `false`.
- Introduced a new `closeButtonTemplate` input property that allows templating the default close icon `x`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid explaining this in such detail in the changelog. There are component READMEs for this purpose and the Changelog can link to them. Please trim this substantially in favor of a robust tooltip README of how everything works now

@RivaIvanova
Copy link
Member Author

@ChronosSF
Yes, this is to avoid breaking changes. During the meeting, there was a suggestion to wrap the WC tooltip for use in Angular, but due to the massive breaking changes that would likely result, it was decided against it, at least for now. The main goal was to ensure parity between the WC tooltip and the Angular tooltip without any major breaking changes.

@ChronosSF ChronosSF self-requested a review August 18, 2025 10:39
ChronosSF
ChronosSF previously approved these changes Aug 18, 2025
View reviewed changes
@MonikaKirkova MonikaKirkova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Aug 18, 2025
@RivaIvanova RivaIvanova requested a review from ChronosSF August 19, 2025 11:08
@kacheshmarova kacheshmarova merged commit 11ead5a into master Aug 19, 2025
2 of 4 checks passed
@kacheshmarova kacheshmarova deleted the feature/align-tooltip branch August 19, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev left review comments

@ChronosSF ChronosSF ChronosSF approved these changes

@simeonoff simeonoff Awaiting requested review from simeonoff

Assignees

@MonikaKirkova MonikaKirkova

Labels
squash-merge Merge PR with "Squash and Merge" option tooltip ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tooltip] Align the tooltip with the implementation in WC
7 participants
@RivaIvanova @ChronosSF @damyanpetev @kacheshmarova @MonikaKirkova @Zneeky @didimmova