Skip to content

feat(switch): improve switch theme #15699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

feat(switch): improve switch theme #15699

merged 3 commits into from
Apr 17, 2025

Conversation

didimmova
Copy link
Contributor

Closes #15590

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@didimmova didimmova added switch ❌ status: awaiting-test PRs awaiting manual verification ✨ themes labels Apr 9, 2025
@didimmova didimmova requested a review from simeonoff April 9, 2025 07:03
@didimmova didimmova linked an issue Apr 9, 2025 that may be closed by this pull request
Improve Switch Theme #15590
Closed
SisIvanova
SisIvanova reviewed Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@SisIvanova SisIvanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the updates look good to me, but what about the disabled colors in all other themes except Material? Also, should we handle the scenario where the user provides track-off-color but no thumb-off-color?

@SisIvanova SisIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 16, 2025
@SisIvanova SisIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 17, 2025
@simeonoff simeonoff merged commit 846fbde into didimmova/improve-component-themes Apr 17, 2025
@simeonoff simeonoff deleted the didimmova/improve-switch-theme branch April 17, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SisIvanova SisIvanova SisIvanova approved these changes

@simeonoff simeonoff Awaiting requested review from simeonoff

Assignees

@simeonoff simeonoff

Labels
✨ themes switch ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Switch Theme
3 participants
@didimmova @SisIvanova @simeonoff