Skip to content

Fix disable summaries sample logic #3922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarielaTihova wants to merge 1 commit into
base: vnext
Choose a base branch
from
Open

Fix disable summaries sample logic #3922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/app/grid/grid-disable-summaries/grid-disable-summaries.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="grid-wrapper">
<div class="summaries">
<h5 class="summaries-title">Disable Summaries for Column:</h5>
<h5 class="summaries-title">Toggle Summaries for Column:</h5>
@for (column of columns; track column; let i = $index) {
<div class="summary-column-button">
<button
Expand Down Expand Up @@ -30,14 +30,14 @@ <h5 class="summaries-title">Disable Summaries for Column:</h5>
</div>
<div class="summaries-dropdown-buttons">
<button igxButton="flat"
[disabled]="getCheckedSummariesCount(column.summaries) === column.summaries.length"
(click)="checkAllColumns(column)"
[disabled]="getCheckedSummariesCount(column.summaries) === 0"
(click)="uncheckAllColumns(column)"
>
Disable All
</button>
<button igxButton="flat"
[disabled]="getCheckedSummariesCount(column.summaries) === 0"
(click)="uncheckAllColumns(column)"
[disabled]="getCheckedSummariesCount(column.summaries) === column.summaries.length"
(click)="checkAllColumns(column)"
>
Enable All
</button>
Expand Down
10 changes: 5 additions & 5 deletions src/app/grid/grid-disable-summaries/grid-disable-summaries.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export class GridDisableSummariesComponent implements OnInit, AfterViewInit {
this.buttonsArray = this.buttons.toArray();

this.columns.forEach((column, index) => {
column.summaries = this.getSummaries(column.field)
column.summaries = this.getSummaries(column.field);
});
}

Expand All @@ -241,7 +241,7 @@ export class GridDisableSummariesComponent implements OnInit, AfterViewInit {

public toggleCheckbox(event: any, index: number, column: any): void {
column.summaries[index].checked = event.checked;
if (event.checked) {
if (!event.checked) {
this.grid1.getColumnByName(column.field).disabledSummaries = [
...this.grid1.getColumnByName(column.field).disabledSummaries,
column.summaries[index].summaryKey
Expand All @@ -255,12 +255,12 @@ export class GridDisableSummariesComponent implements OnInit, AfterViewInit {

public uncheckAllColumns(column: any): void {
column.summaries.forEach(summary => (summary.checked = false));
this.grid1.getColumnByName(column.field).disabledSummaries = [];
this.grid1.getColumnByName(column.field).disabledSummaries = column.summaries.map(summary => summary.summaryKey);
}

public checkAllColumns(column: any): void {
column.summaries.forEach(summary => (summary.checked = true));
this.grid1.getColumnByName(column.field).disabledSummaries = column.summaries.map(summary => summary.summaryKey);
this.grid1.getColumnByName(column.field).disabledSummaries = [];
}

private getSummaries(columnName: string): any[] {
Expand All @@ -272,7 +272,7 @@ export class GridDisableSummariesComponent implements OnInit, AfterViewInit {
.map((summary) => ({
summaryKey: summary.key,
summaryLabel: summary.label,
checked: false
checked: true
}));
}
}