-
Notifications
You must be signed in to change notification settings - Fork 0
Ttonev/hr portal latest #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could you please remove the routing from the app. We dont need all that boilerplate. Also, delete the files that you dont need.
- When running
npm run build
an error is thrown
…d-demos-react into ttonev/hr-portal-latest
Please inside the project/hr-portal remove the routing since it is not needed. |
…from there for the main app
…emos-react into ttonev/hr-portal-latest
…/grid-demos-react into ttonev/hr-portal-latest
I had to make some changes to the sales grid in order for the build not to fail, not sure but the sales branch was not failing as it was, or i have warnings to pop as errors. |
…/grid-demos-react into ttonev/hr-portal-latest
@@ -0,0 +1,59 @@ | |||
body { | |||
margin: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need these styles for margin of the body both here and in styles.scss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just one element so I removed the body completely
const gridRef = useRef<IgrTreeGrid | null>(null); | ||
|
||
useEffect(() => { | ||
dataService.fetchData().then((fetchedData: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please introduce some data types and use them both here, in the service and wherever needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i created an interface in the data service and imported it from there. If you would like it to be in the main app please let me know
}; | ||
|
||
const dateTemplate = ({ cell }: IgrCellTemplateContext) => { | ||
const data = cell.row.data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use cell.row.data here? You only need the value of the column here formatted in some way. You can remove the { } around cell and use .cell.value instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was for consistency with the rest of the templates, but if you think this way is better i am with you so I have changed it
…/grid-demos-react into ttonev/hr-portal-latest
No description provided.