Ttonev/hr portal latest #6
Conversation
|
When building and running the main app( npm run build and npm run preview), routing to the sample seems to be incorrect as it currently loads the wrong view from the hr-portal-view and not the actual sample: |
it is building for me, can you please show what error it throws: If it is regarding the main app as per maya's comment, I have updated the routes for the hr-portal, the rest of the apps still point towards the view tho |
…d-demos-react into ttonev/hr-portal-latest
|
Please inside the project/hr-portal remove the routing since it is not needed. |
…from there for the main app
…emos-react into ttonev/hr-portal-latest
…/grid-demos-react into ttonev/hr-portal-latest
|
I had to make some changes to the sales grid in order for the build not to fail, not sure but the sales branch was not failing as it was, or i have warnings to pop as errors. |
…/grid-demos-react into ttonev/hr-portal-latest
| @@ -0,0 +1,59 @@ | |||
| body { | |||
| margin: 0; | |||
There was a problem hiding this comment.
Do you need these styles for margin of the body both here and in styles.scss?
There was a problem hiding this comment.
It's just one element so I removed the body completely
| const gridRef = useRef<IgrTreeGrid | null>(null); | ||
|
|
||
| useEffect(() => { | ||
| dataService.fetchData().then((fetchedData: any) => { |
There was a problem hiding this comment.
Please introduce some data types and use them both here, in the service and wherever needed
There was a problem hiding this comment.
i created an interface in the data service and imported it from there. If you would like it to be in the main app please let me know
| }; | ||
|
|
||
| const dateTemplate = ({ cell }: IgrCellTemplateContext) => { | ||
| const data = cell.row.data; |
There was a problem hiding this comment.
Why use cell.row.data here? You only need the value of the column here formatted in some way. You can remove the { } around cell and use .cell.value instead
There was a problem hiding this comment.
It was for consistency with the rest of the templates, but if you think this way is better i am with you so I have changed it
MarielaTihova
added
✅ status: verified
…/grid-demos-react into ttonev/hr-portal-latest
No description provided.