Add Sales Grid project and tabs implementation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine for each sample. Add Sales Grid into main app.
This reverts commit 8f21d49.
…e new project. Small fixes.
|
Also, what about all the generated code from the AB? At what point are we gonna do a clean-up? |
MayaKirova
added
💥 status: in-test
|
If you configure the pivot so that it has some empty values (Rows: All Periods + Country, Columns: Brand, Store), it shows them as $NaN:
Other than that and some issues that have pending fixes in angular, LGTM. |
skrustev
added
❌ status: awaiting-test
mddragnev
approved these changes
Apr 22, 2025
tishko0
added
✅ status: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes IgniteUI/grid-demos#105 for React as well.